tool: add recursive structure support in JSON schema #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement $ref and $defs in schema generator to handle recursive and mutually recursive data structures.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
===================================================
- Coverage 74.83858% 74.82443% -0.01415%
===================================================
Files 195 195
Lines 29891 30045 +154
===================================================
+ Hits 22370 22481 +111
- Misses 6339 6375 +36
- Partials 1182 1189 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
liuzengh
changed the title
sandyskies
approved these changes
Oct 17, 2025
internal/tool/tool.go
Outdated
| } | ||
|
|
||
| // generateJSONSchemaWithContextInternal generates a JSON schema with recursion handling | ||
| func generateJSONSchemaWithContextInternal(t reflect.Type, ctx *schemaContext, isRoot bool) *tool.Schema { |
There was a problem hiding this comment.
cyclomatic complexity 21 of func generateJSONSchemaWithContextInternal is high (> 20) (gocyclo)
There was a problem hiding this comment.
这个 PR 还有点实现的问题，修复好了之后，我主动找你看下
liuzengh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement $ref and $defs in schema generator to handle recursive and mutually recursive data structures.
https://json-schema.org/draft/2020-12/json-schema-core#name-schema-re-use-with-defs