-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Adami loop flipping optimization optional #581
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
- Coverage 68.51% 68.50% -0.02%
==========================================
Files 87 87
Lines 5406 5407 +1
==========================================
Hits 3704 3704
- Misses 1702 1703 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@svchb do you remember what we did with this? Did we implement it somewhere else? Or did we just forget about it? |
The optimization is there because there are cases where the larger system is looped over and there are no/only a small number of neighbors between systems. In my simulations this made up to a 20% difference in run time. One side effect is though that if you run the validation cases with different numbers of threads the results change. |
Yes, I know. This PR is based on your PR, so the diff is messy. But did we make the flipping optional and disable it for validiation? Or did we forget about it? Or did we decide not to do this for some reason? |
d84ae1e
to
9ef452c
Compare
Just rebased to make the diff useful. |
No this was not merged. You also did not create all the validation files correctly. I think this was the latest on this PR. |
Depends on #498.
I now get an error of
0.0
for the dam break validation between a single threads and 128 threads on an AMD Threadripper 3990X. So we can generate all validation files on as many threads as we have available.