-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Draft JOSS paper #107
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
+ Coverage 74.88% 75.83% +0.94%
==========================================
Files 68 68
Lines 10429 10568 +139
Branches 2 2
==========================================
+ Hits 7810 8014 +204
+ Misses 2619 2554 -65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add contents to paper, bib, and three new figures.
Fix issues with markdown
add spaces after # and fix figure reference.
Fix another space after hashtag
Fix typos
… into paper-2024-joss
I have put in most of the suggestions from the group into the draft. We are over the word limit as currently we are at 1132 and the max JOSS allows is 1000. This is one reason I trimmed down the suggested description of HOHQMesh.jl. Apart from editing, the remaining things that need done are:
|
Use format suggested by JOSS for github repositories.
Remove a couple of sentences to bring word count below 1K
Add a clarification on what is meshed.
I have never seen a JOSS review process where the number of words was an issue. The formulation
sounds to me like we don't have to reduce the number of words if we slightly exceed 1000 words. |
Co-authored-by: Hendrik Ranocha <[email protected]>
Add citations in the "Statement of Need" section with papers published with meshes from HOHQMesh.
Remove flow computation figure. Add links to the Malpasset control file, the gallery and the examples. Mention that meshes are generated as part of the test operation.
This reverts commit fd3c838.
* Update paper.md Remove flow computation figure. Add links to the Malpasset control file, the gallery and the examples. Mention that meshes are generated as part of the test operation. * Update paper.md Add flow computation back in. --------- Co-authored-by: David Kopriva <[email protected]>
* Small edits * Update paper.md Co-authored-by: Michael Schlottke-Lakemper <[email protected]> --------- Co-authored-by: Andrew Winters <[email protected]> Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
* Update paper.md * Update paper.bib
Nice work everyone! The paper is now published and available at https://doi.org/10.21105/joss.07476. I will close this PR but not delete the branch. |
WARNING: DO NOT MERGE THIS PR!
This PR is to facilitate writing an initial JOSS paper on HOHQMesh. It should not be merged (ever!). Instead, once the paper is accepted, this PR can be closed without deleting the branch. The branch
paper-2024-joss
will just stay around forever.Latest build of
paper.pdf
: view, downloadBased on the TODO list in openjournals/joss-reviews#7476: