[wip] implement accessible dropdown selection#14
Open
andrewharvey wants to merge 2 commits intotristen:gh-pagesfrom
Open
[wip] implement accessible dropdown selection#14andrewharvey wants to merge 2 commits intotristen:gh-pagesfrom
andrewharvey wants to merge 2 commits intotristen:gh-pagesfrom
Conversation
Owner
|
@andrewharvey is this ready to go? code lgtm |
Collaborator
Author
|
@tristen Not yet, I'm still working to resolve:
However all my other PR's for suggestions and for mapbox-gl-geocoder are ready for review. |
Collaborator
Author
|
It looks like there's a new ARIA standard for implementing accessibility for these drop down lists, with the approach implementing in this PR now legacy. https://www.w3.org/TR/wai-aria-practices/examples/listbox/listbox-collapsible.html It looks like the new standard requires using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on making the dropdown selection more accessible for screen readers. I need to do more testing and fix some minor issues.