Skip to content

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Oct 16, 2025

Description

Fixes #24744

Release notes

## Iceberg
* Fix failure when executing `SHOW CREATE SCHEMA` on a schema with unsupported properties with
  REST, Glue or Nessie catalog. ({issue}`24744`)

Summary by Sourcery

Filter out unsupported namespace properties to avoid failures in SHOW CREATE SCHEMA and ensure only the LOCATION property is retained when loading namespace metadata across Iceberg catalogs.

Bug Fixes:

  • Filter out non-LOCATION namespace properties in REST and Nessie catalogs during loadNamespaceMetadata
  • Remove propagation of Glue catalog database parameters so only LOCATION_PROPERTY is returned

Enhancements:

  • Introduce abstract createNamespaceWithProperties helper in BaseTrinoCatalogTest and implement it in each catalog test

Tests:

  • Add testSchemaWithInvalidProperties to verify unsupported namespace properties are ignored

@cla-bot cla-bot bot added the cla-signed label Oct 16, 2025

This comment was marked as resolved.

@github-actions github-actions bot added the iceberg Iceberg connector label Oct 16, 2025
sourcery-ai[bot]

This comment was marked as resolved.

@ebyhr ebyhr force-pushed the ebi/iceberg-show-create-schema branch from 3121178 to 12ecfdc Compare October 16, 2025 08:26
try {
return ImmutableMap.copyOf(nessieClient.loadNamespaceMetadata(Namespace.of(namespace)));
return nessieClient.loadNamespaceMetadata(Namespace.of(namespace)).entrySet().stream()
.filter(metadata -> metadata.getKey().equals(LOCATION_PROPERTY))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a method that says "isSupportedProperty" ?

@ebyhr ebyhr force-pushed the ebi/iceberg-show-create-schema branch from 12ecfdc to c4873ff Compare October 21, 2025 02:01
@ebyhr ebyhr force-pushed the ebi/iceberg-show-create-schema branch from c4873ff to df4adbf Compare October 22, 2025 01:48
@ebyhr ebyhr merged commit 1d69dc5 into master Oct 22, 2025
46 checks passed
@ebyhr ebyhr deleted the ebi/iceberg-show-create-schema branch October 22, 2025 03:18
@github-actions github-actions bot added this to the 478 milestone Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed iceberg Iceberg connector

Development

Successfully merging this pull request may close these issues.

SHOW CREATE SCHEMA on Glue fails when the database contains parameters

2 participants