Test iceberg_tables function with TrinoSnowflakeCatalog #24593
Conversation
| String schemaTablesValues = "VALUES " + getQueryRunner() | ||
| .execute("SELECT table_schema, table_name FROM iceberg.information_schema.tables WHERE table_schema='%s'".formatted(SNOWFLAKE_TEST_SCHEMA.toLowerCase(ENGLISH))) | ||
| .getMaterializedRows().stream() | ||
| .map(row -> "('%s', '%s')".formatted(row.getField(0), row.getField(1))) | ||
| .collect(joining(", ")); | ||
| assertQuery("SELECT * FROM TABLE(iceberg.system.iceberg_tables(SCHEMA_NAME => '%s'))".formatted(SNOWFLAKE_TEST_SCHEMA.toLowerCase(ENGLISH)), schemaTablesValues); |
There was a problem hiding this comment.
I think this test is flaky. What happens if a new object is created after listing iceberg.information_schema.tables and before executing iceberg_tables function?
There was a problem hiding this comment.
That was the reason the generic test creates its own schemas but in this case, it is not needed because this test does not create iceberg tables other than potentially during setup.
There is one test that creates a native table but that will not be listed by TrinoSnowflakeCatalog#listTables
|
@ebyhr could you run with secrets to actually run this test? |
|
/test-with-secrets sha=181dc8c8651fdc68b83c9d3d520ef87e13a3f6b7 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12583104964 |
Description
Implement a simple test for the
system.iceberg_tables tablefunction for theTrinoSnowflakeCatalog.Since
TrinoSnowflakeCatalogis read only the original generic test does not work.Theoretically, we could apply the modifications directly on the snowflake to match the generic test with multiple schemas. However, that seems like an overkill given the implementation just delegates to the
listTablesmethod and maps the results.Additional context and related issues
Release notes
( X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: