Remove unreachable code in OrderedPeriodParser

trinodb · Dec 30, 2024 · effac4f · effac4f
1 parent e8cc8e3
commit effac4f
Showing 1 changed file with 4 additions and 16 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/util/DateTimeUtils.java b/core/trino-main/src/main/java/io/trino/util/DateTimeUtils.java
@@ -408,8 +408,6 @@ public int parseInto(ReadWritablePeriod period, String text, int position, Local
             int bestValidPos = position;
             ReadWritablePeriod bestValidPeriod = null;
 
-            int bestInvalidPos = position;
-
             for (PeriodParser parser : parsers) {
                 ReadWritablePeriod parsedPeriod = new MutablePeriod();
                 int parsePos = parser.parseInto(parsedPeriod, text, position, locale);
@@ -422,23 +420,13 @@ public int parseInto(ReadWritablePeriod period, String text, int position, Local
                         }
                     }
                 }
-                else if (parsePos < 0) {
-                    parsePos = ~parsePos;
-                    if (parsePos > bestInvalidPos) {
-                        bestInvalidPos = parsePos;
-                    }
-                }
             }
 
-            if (bestValidPos > position || (bestValidPos == position)) {
-                // Restore the state to the best valid parse.
-                if (bestValidPeriod != null) {
-                    period.setPeriod(bestValidPeriod);
-                }
-                return bestValidPos;
+            // Restore the state to the best valid parse.
+            if (bestValidPeriod != null) {
+                period.setPeriod(bestValidPeriod);
             }
-
-            return ~bestInvalidPos;
+            return bestValidPos;
         }
     }
 }