Skip to content

Run CI tests only if Trino and Gateway file change #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dingo4dev
Copy link
Member

@dingo4dev dingo4dev commented May 26, 2025

This pull request updates the CI/CD workflow to conditionally run tests (#345). The kind cluster setup and tests will be skipped if there are no changes detected in pull requests or push events.

Trino Tests: detect changes in

  • charts/trino/**,
  • tests/trino/**,
  • .helmignore
  • .github/**
  • .gitignore

Gateway Tests: detect changes in

  • charts/gateway/**,
  • tests/gateway/**,
  • .helmignore
  • .github/**
  • .gitignore

@cla-bot cla-bot bot added the cla-signed label May 26, 2025
@dingo4dev dingo4dev marked this pull request as ready for review May 26, 2025 23:40
@dingo4dev
Copy link
Member Author

For show clearly skip state on actions, I think it's better to skip jobs instead of steps

@dingo4dev dingo4dev marked this pull request as draft May 27, 2025 03:28
@dingo4dev dingo4dev marked this pull request as ready for review May 27, 2025 04:17
Copy link
Member

@nineinchnick nineinchnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all commits when the PR is ready for review.

@dingo4dev dingo4dev force-pushed the ci-helm-tests-affected-chart-only branch from 7cb8c70 to 337705c Compare May 27, 2025 10:12
@dingo4dev
Copy link
Member Author

TBR

@nineinchnick nineinchnick added the ignore-for-release This will NOT be mentioned in release notes label May 28, 2025
@nineinchnick nineinchnick changed the title ci: add conditional helm tests only for Trino and Gateway file changes Add conditional helm tests only for Trino and Gateway file changes May 28, 2025
@nineinchnick nineinchnick changed the title Add conditional helm tests only for Trino and Gateway file changes Run CI tests only for Trino and Gateway file changes May 28, 2025
@nineinchnick nineinchnick changed the title Run CI tests only for Trino and Gateway file changes Run CI tests only if Trino and Gateway file change May 28, 2025
@nineinchnick nineinchnick merged commit 7a96300 into trinodb:main May 28, 2025
11 checks passed
@dingo4dev dingo4dev deleted the ci-helm-tests-affected-chart-only branch June 5, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed ignore-for-release This will NOT be mentioned in release notes
Development

Successfully merging this pull request may close these issues.

2 participants