fix: categorize lecture as an enum#1481
Merged
squell merged 1 commit intotrifectatechfoundation:mainfrom Mar 4, 2026
Merged
Conversation
Contributor
Author
|
just firing this off real quick before i head out - will add test cases for the different enum values later today or early tomorrow. |
squell
approved these changes
Mar 4, 2026
This change categorizes the lecture setting as an enum to avoid a validation failure in sudoers configuration containing this setting (causing visudo to yell about an invalid configuration file). Closes: trifectatechfoundation#399
Contributor
Author
|
@squell thanks for the early approval, which reminded me about this :) i added test cases for the different enum values (including the default), and rebased on top of the latest upstream commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change categorizes the lecture setting as an enum to avoid a validation failure in sudoers configuration containing this setting (causing visudo to yell about an invalid configuration file).
Closes: #399