fix(firmware): add missing requried true to JSONs release #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we changed to the new releases JSONs, we used trezor/data as source of truth, but it was actually not really 100% since there were previous changes that were done to the copy of those releases JSONs in Suite but not here, this PR is trying to align with that
Issue in Suite trezor/trezor-suite#22028
PR in Suite that is adding the changes trezor/trezor-suite#22135
Link to old commit were those releases.json were still in Suite and they had some
"required": truedifferent with the ones in trezor/data repository - https://github.com/trezor/trezor-suite/tree/0c16c5f1fc2cdf2c394afa9b0e99a0787d7d9d5d/packages/connect-common/files/firmware