Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python.md #8541

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Update python.md #8541

merged 2 commits into from
Feb 12, 2025

Conversation

offirc2
Copy link
Contributor

@offirc2 offirc2 commented Jan 22, 2025

Fix some typos in python examples

Fix some typos in examples
@offirc2 offirc2 requested review from N-o-Z and Isan-Rivkin January 22, 2025 14:55
Copy link

github-actions bot commented Jan 22, 2025

♻️ PR Preview e933afa has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link

github-actions bot commented Jan 22, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

14 passed

Copy link

E2E Test Results - Quickstart

11 passed

Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one comment

@@ -147,7 +147,7 @@ print(repo)
import lakefs

print("Listing repositories:")
for repo in lakefs.repositories():
for repo in lakefs.repositories(client=clt):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the main use-case. The main use case is to use the default client.
I assuming this is relevant for the SSL configuration

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change

@N-o-Z
Copy link
Member

N-o-Z commented Feb 11, 2025

@offirc2 What's the status with this PR?

Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@N-o-Z N-o-Z assigned N-o-Z and offirc2 and unassigned N-o-Z Feb 12, 2025
@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels Feb 12, 2025
@offirc2 offirc2 merged commit 91343f0 into master Feb 12, 2025
41 of 43 checks passed
@offirc2 offirc2 deleted the offirc2-patch-1 branch February 12, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants