-
Notifications
You must be signed in to change notification settings - Fork 57
Add edit capability to the hex editor #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Does not allow editing flash and bootloader.
Update hex editor to not do polling
|
Sweet! Some quick questions, which might all have the same answer:
|
|
|
Well yes, but what happens with a write that is not allowed? Is the write silently ignored or does the watch reboot? |
|
When the write is not allowed, the watch does not allow entering a new value. See here. Does this answer your question or is your question what happens if |
|
Yes, I'm interested in what happens when writes are made to those three addresses, just to make sure that none of them trigger a reboot. |
Would it make sense to add support for editing flash to the hex editor? |
|
Ignoring writes to Flash is totally fine. I'll try to test this code this week and get it merged. |
|
Were you able to do any testing of this? |
|
I wasn't, but I really ought to. Perhaps there should be a testing branch that works its way to master? This will be my first patch to test after I dust off my development kit and wire it up in the new lab. |
|
I'm hoping to finish assembling eight new watch boards this weekend, will try pulling in those PRs and wearing the code for a while. |
The long awaited feature[citation needed] is finally here!
This adds the ability to edit memory with the hex editor.
Support for blacklisting of memory regions to edit is included. The blacklist is separate from the read blacklist.
Usage:
Set button enters and exits edit mode. In edit mode, the mode button will advance to the next digit.
The keypad is layed out as follows.