Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token used for scorecard #198

Merged

Conversation

mhutchinson
Copy link
Contributor

This was previously using a github secret that was per-repo. I've switched it over to an org-level secret, which should allow us to avoid copying and pasting the secret around a number of times. Added a note that we should switch over to branch protection rulesets instead, which should mean that this read permission isn't needed at all.

Motivation is that the original token is expiring within the week.

@mhutchinson mhutchinson requested a review from phbnf August 7, 2024 09:45
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9082bd0). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage        ?   31.17%           
=======================================
  Files           ?        8           
  Lines           ?      526           
  Branches        ?        0           
=======================================
  Hits            ?      164           
  Misses          ?      333           
  Partials        ?       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was previously using a github secret that was per-repo. I've switched it over to an org-level secret, which should allow us to avoid copying and pasting the secret around a number of times. Added a note that we should switch over to branch protection rulesets instead, which should mean that this read permission isn't needed at all.

Motivation is that the original token is expiring within the week.
@mhutchinson mhutchinson force-pushed the scorecard-updateToken branch from 60d7b71 to 3766ffd Compare August 7, 2024 10:33
@mhutchinson mhutchinson merged commit d878df5 into transparency-dev:main Aug 7, 2024
6 checks passed
@mhutchinson mhutchinson deleted the scorecard-updateToken branch August 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants