Expose an endpoint with all of the witness keys #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of the environments will be configured differently, and thus using the single embedded config on both the client and the server to enumerate the witnesses was brittle/broken. This change temporarily breaks the client until all distributors are updated to have the new endpoint, but we're still at v0 and I'll get this rolled out within a matter of hours so I'll avoid the tax of doing this the staged way. This is also a breaking change at the code level, but again, this is v0 and we can flex that licence.
mhutchinson
force-pushed
the
exposeWitnesses
branch
from
d94b4a5 to
d3ac99e
Compare
AlCutter
approved these changes
Feb 27, 2024
mhutchinson
added a commit
to mhutchinson/distributor
that referenced
this pull request
Mar 7, 2024
This got broken when the initialization of the distributor took the raw vkeys in transparency-dev#114. The tests passed because they were still passing in the friendly names.
mhutchinson
added a commit
that referenced
this pull request
Mar 7, 2024
This got broken when the initialization of the distributor took the raw vkeys in #114. The tests passed because they were still passing in the friendly names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of the environments will be configured differently, and thus using the single embedded config on both the client and the server to enumerate the witnesses was brittle/broken.
This change temporarily breaks the client until all distributors are updated to have the new endpoint, but we're still at v0 and I'll get this rolled out within a matter of hours so I'll avoid the tax of doing this the staged way. This is also a breaking change at the code level, but again, this is v0 and we can flex that licence.