Clean up some TODOs (#104)

The ko builder doesn't really work for our deployment because it does the build at the point where terraform is run, not hooked into cloud build.
transparency-dev · Feb 22, 2024 · b49207c · b49207c
1 parent 61a169f
commit b49207c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/cmd/internal/distributor/distributor_test.go b/cmd/internal/distributor/distributor_test.go
@@ -750,7 +750,7 @@ func TestGetCheckpointNHistoric(t *testing.T) {
 			wantSize: 22,
 		},
 		{
-			desc: "TODO: N=2 can get historic version where both were in sync together",
+			desc: "N=2 can get historic version where both were in sync together",
 			order: []witnessAndSize{
 				{
 					witChameleon,
@@ -788,7 +788,7 @@ func TestGetCheckpointNHistoric(t *testing.T) {
 			reqN:        2,
 			wantErr:     true,
 			wantErrCode: codes.NotFound,
-			// TODO(mhutchinson): this case should work with the following assertions
+			// TODO(#103): this case should work with the following assertions
 			// wantErr: false,
 			// wantSize: 10,
 		},

diff --git a/deployment/modules/cloudbuild/main.tf b/deployment/modules/cloudbuild/main.tf
@@ -42,7 +42,6 @@ resource "google_cloudbuild_trigger" "distributor_docker" {
     }
   }
 
-  # TODO(mhutchinson): Consider replacing this with https://github.com/ko-build/terraform-provider-ko
   build {
     step {
       name = "gcr.io/cloud-builders/docker"
-Original file line number
+Diff line change
@@ Expand Up / @@ -42,7 +42,6 @@ resource "google_cloudbuild_trigger" "distributor_docker" { @@
         }
       }
-      # TODO(mhutchinson): Consider replacing this with https://github.com/ko-build/terraform-provider-ko
       build {
         step {
           name = "gcr.io/cloud-builders/docker"
@@ Expand Down @@