@uppy/dashboard: fix form appending for shadow dom #6031
Conversation
🦋 Changeset detectedLatest commit: edf81e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Murderlon
changed the title
|
@Murderlon I couldn't get it to work under WSL either, sorry :( |
|
Can you remove the dev setup and resolve the CI errors? |
|
@Murderlon As requested, I removed the "dashboard_shadow.html" file and addressed the lint issues. Thank you for your consideration. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| * Use the "rootNode" of whereever Uppy is rendered, falling back | ||
| * to `window.document` if domRef isn't initialized for some reason | ||
| */ | ||
| const rootNode = domRef.current?.getRootNode() ?? (document as Node) |
There was a problem hiding this comment.
Bug: Guarding getRootNode: handle absent method gracefully
domRef.current?.getRootNode() only guards domRef.current being nullish, not the presence of getRootNode. In environments where Node.getRootNode is undefined (older/legacy browsers or certain polyfilled contexts), this will throw TypeError: getRootNode is not a function. Use domRef.current?.getRootNode?.() (or a safe fallback like ownerDocument) to avoid a runtime crash.
2 participants
Fixes #6028
I've also added
private/dev/dashboard_shadow.htmlto more easily test ShadowDOM-specific bugs.I looked into writing a test case under
packages/@uppy/dashboard/src/index.browser.test.tsbut couldn't get it to work locally on Windows.Note
Ensure FileCard’s hidden form is appended/cleaned up in the correct root (Document body or ShadowRoot) using a ref-derived root node, and add a patch changeset.
formto the correct root usinggetRootNode()(handles Light DOM/iframes viaDocument.body, and Shadow DOM viaShadowRoot).domRefto root element to detect rendering context; attachrefand update effect accordingly.formfrom its actualparentNode.Fix form appending for shadow dom.Written by Cursor Bugbot for commit edf81e8. This will update automatically on new commits. Configure here.