Add onConnection option for WebSocket authentication in Companion #5980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
onConnectioncallback option to Uppy Companion for authenticating WebSocket connections, addressing security concerns raised in #5922.Problem
The WebSocket endpoint for upload progress (
/api/<token>) had no authentication mechanism, creating a potential security vulnerability. Security auditors flagged this as a concern since anyone could potentially connect to these WebSocket endpoints without authorization.Solution
This PR introduces an optional
onConnectioncallback that allows developers to implement custom authentication logic for WebSocket connections:Key Features
Implementation Details
onConnection: nullto default companion optionssetupSocketto accept options parameter and call authentication callbacksetupSocketfunction with options boundTesting
All existing tests continue to pass (114/114), plus new tests covering:
The implementation is minimal and surgical, adding only the requested security feature without any breaking changes to existing APIs.
Fixes #5922
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.