@uppy/companion: fix forcePathStyle boolean conversion #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff output filesdiff --git a/packages/@uppy/companion/lib/server/s3-client.js b/packages/@uppy/companion/lib/server/s3-client.js
index 9d6827e..b513b45 100644
--- a/packages/@uppy/companion/lib/server/s3-client.js
+++ b/packages/@uppy/companion/lib/server/s3-client.js
@@ -30,7 +30,7 @@ module.exports = (companionOptions, createPresignedPostMode = false) => {
/** @type {import('@aws-sdk/client-s3').S3ClientConfig} */
let s3ClientOptions = {
region: s3.region,
- forcePathStyle: Boolean(s3.forcePathStyle),
+ forcePathStyle: s3.forcePathStyle,
};
if (s3.useAccelerateEndpoint) {
// https://github.com/transloadit/uppy/issues/4809#issuecomment-1847320742 |
Murderlon
changed the title
github-actions bot
added a commit
that referenced
this pull request
Jan 15, 2025
| Package | Version | Package | Version | | --------------- | ------- | --------------- | ------- | | @uppy/aws-s3 | 4.2.2 | @uppy/unsplash | 4.3.2 | | @uppy/companion | 5.5.0 | uppy | 4.13.0 | - @uppy/aws-s3: always set S3 meta to UppyFile & include key (Merlijn Vos / #5602) - @uppy/companion: fix forcePathStyle boolean conversion (Mikael Finstad / #5308) - meta: Fix Webpack CI (Merlijn Vos / #5604) - @uppy/aws-s3: allow uploads to fail/succeed independently (Merlijn Vos / #5603) - meta: Add types for css files (Merlijn Vos / #5591) - @uppy/unsplash: make utmSource optional (Merlijn Vos / #5601) - meta: build(deps): bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (dependabot[bot] / #5599) - meta: build(deps): bump docker/build-push-action from 6.10.0 to 6.11.0 (dependabot[bot] / #5600) - @uppy/companion: add COMPANION_TUS_DEFERRED_UPLOAD_LENGTH (Dominik Schmidt / #5561)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5066 (comment)