Skip to content

@uppy/utils: add cause support for AbortErrors #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022
Merged

@uppy/utils: add cause support for AbortErrors #4198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
250bc12
@uppy/utils: add `cause` support for `AbortError`s
aduh95 Nov 7, 2022
e130caa
fixup! @uppy/utils: add `cause` support for `AbortError`s
aduh95 Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/@uppy/utils/src/AbortController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import hasOwnProperty from './hasProperty.js'
/**
* Little AbortController proxy module so we can swap out the implementation easily later.
*/
export const { AbortController } = globalThis
export const { AbortSignal } = globalThis
export const createAbortError = (message = 'Aborted') => new DOMException(message, 'AbortError')
export const createAbortError = (message = 'Aborted', options) => {
const err = new DOMException(message, 'AbortError')
if (options != null && hasOwnProperty(options, 'cause')) {
Object.defineProperty(err, 'cause', { __proto__: null, configurable: true, writable: true, value: options.cause })
}
return err
}
2 changes: 1 addition & 1 deletion packages/@uppy/utils/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ declare module '@uppy/utils/lib/toArray' {
declare module '@uppy/utils/lib/AbortController' {
export const AbortController: typeof globalThis.AbortController
export const AbortSignal: typeof globalThis.AbortSignal
export function createAbortError(message?: string): DOMException
export function createAbortError(message?: string, options?: ErrorOptions): DOMException
}

declare module '@uppy/utils/lib/getDroppedFiles' {
Expand Down