@uppy/companion: migrate from Jest to node:test

.eslintrc.js

@@ -325,6 +325,9 @@ module.exports = {
     },
     {
       files: ['./packages/@uppy/companion/**/*.js'],
+      env: {
+        jest: false,
+      },
       rules: {
         'no-underscore-dangle': 'off',
 

packages/@uppy/companion/package.json

@@ -82,10 +82,11 @@
     "@types/request": "2.48.4",
     "@types/webpack": "^5.28.0",
     "@types/ws": "6.0.4",
-    "into-stream": "^6.0.0",
-    "jest": "^27.0.6",
+    "expect": "^28.1.3",
+    "jest-mock": "^28.1.3",
     "nock": "^13.1.3",
-    "supertest": "3.4.2",
+    "supertest": "^6.2.0",
+    "test": "^3.2.1",
     "typescript": "~4.4"
   },
   "files": [
@@ -107,7 +108,7 @@
     "deploy": "kubectl apply -f infra/kube/companion-kube.yml",
     "prepublishOnly": "yarn run build",
     "start": "node ./lib/standalone/start-server.js",
-    "test": "jest"
+    "test": "node--test"
   },
   "engines": {
     "node": "^14.19.0 || ^16.15.0 || >=18.0.0"

packages/@uppy/companion/test/__tests__/callback.js

@@ -1,13 +1,32 @@
-/* global jest:false, test:false, expect:false, describe:false */
-
+const { describe, test } = require('test')
+const expect = require('expect').default
 const mockOauthState = require('../mockoauthstate')()
 
 const request = require('supertest')
 const tokenService = require('../../src/server/helpers/jwt')
 const { getServer } = require('../mockserver')
 
-jest.mock('../../src/server/helpers/oauth-state', () => ({
-  ...jest.requireActual('../../src/server/helpers/oauth-state'),
+function mock (package, replacer) {
+  const actualPath = require.resolve(package)
+  if (arguments.length === 1) {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    require.cache[actualPath] = require(`../__mocks__/${package}`)
+  } else {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    const actual = require(package)
+    const Module = require('node:module') // eslint-disable-line global-require
+    require.cache[actualPath] = new Module(actualPath, module)
+    Object.defineProperties(require.cache[actualPath], {
+      exports: {
+        __proto__: null,
+        value: replacer(actual),
+      },
+      resetFn: { __proto__: null, value: replacer.bind(null, actual) },
+    })
+  }
+}
+mock('../../src/server/helpers/oauth-state', (actual) => ({
+  ...actual,
   ...mockOauthState,
 }))
 

packages/@uppy/companion/test/__tests__/companion.js

@@ -1,17 +1,37 @@
-/* global jest:false, test:false, expect:false, describe:false */
+const { it, describe, it:test, after:afterAll } = require('test')
+const expect = require('expect').default
 
+const request = require('supertest')
+const nock = require('nock')
 const mockOauthState = require('../mockoauthstate')()
 const { version } = require('../../package.json')
 
-jest.mock('tus-js-client')
-jest.mock('purest')
-jest.mock('../../src/server/helpers/oauth-state', () => ({
-  ...jest.requireActual('../../src/server/helpers/oauth-state'),
+function mock (package, replacer) {
+  const actualPath = require.resolve(package)
+  if (arguments.length === 1) {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    require.cache[actualPath] = require(`../__mocks__/${package}`)
+  } else {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    const actual = require(package)
+    const Module = require('node:module') // eslint-disable-line global-require
+    require.cache[actualPath] = new Module(actualPath, module)
+    Object.defineProperties(require.cache[actualPath], {
+      exports: {
+        __proto__: null,
+        value: replacer(actual),
+      },
+      resetFn: { __proto__: null, value: replacer.bind(null, actual) },
+    })
+  }
+}
+mock('tus-js-client')
+mock('purest')
+mock('../../src/server/helpers/oauth-state', (actual) => ({
+  ...actual,
   ...mockOauthState,
 }))
 
-const nock = require('nock')
-const request = require('supertest')
 const tokenService = require('../../src/server/helpers/jwt')
 const { getServer } = require('../mockserver')
 

packages/@uppy/companion/test/__tests__/cors.js

@@ -1,21 +1,21 @@
-/* global jest:false, test:false, describe:false, expect:false */
-
+const { test, describe } = require('test')
+const expect = require('expect').default
 const { cors } = require('../../src/server/middlewares')
 
 function testWithMock ({ corsOptions, get = () => {}, origin = 'https://localhost:1234' } = {}) {
   const res = {
     get,
     getHeader: get,
-    setHeader: jest.fn(),
-    end: jest.fn(),
+    setHeader: Function.prototype,
+    end: Function.prototype,
   }
   const req = {
     method: 'OPTIONS',
     headers: {
       origin,
     },
   }
-  const next = jest.fn()
+  const next = Function.prototype
   cors(corsOptions)(req, res, next)
   return { res }
 }

packages/@uppy/companion/test/__tests__/credentials.js

@@ -1,7 +1,27 @@
-/* global jest:false, test:false, expect:false, describe:false */
+const { test, describe } = require('test')
+const expect = require('expect').default
 
+function mock (package, replacer) {
+  const actualPath = require.resolve(package)
+  if (arguments.length === 1) {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    require.cache[actualPath] = require(`../__mocks__/${package}`)
+  } else {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    const actual = require(package)
+    const Module = require('node:module') // eslint-disable-line global-require
+    require.cache[actualPath] = new Module(actualPath, module)
+    Object.defineProperties(require.cache[actualPath], {
+      exports: {
+        __proto__: null,
+        value: replacer(actual),
+      },
+      resetFn: { __proto__: null, value: replacer.bind(null, actual) },
+    })
+  }
+}
 // mocking request module used to fetch custom oauth credentials
-jest.mock('request', () => {
+mock('request', () => {
   const { remoteZoomKey, remoteZoomSecret, remoteZoomVerificationToken } = require('../fixtures/zoom').expects
 
   return {

packages/@uppy/companion/test/__tests__/deauthorization.js

@@ -1,5 +1,4 @@
-/* global test:false, describe:false */
-
+const { test, describe } = require('test')
 const request = require('supertest')
 const { getServer } = require('../mockserver')
 

packages/@uppy/companion/test/__tests__/header-blacklist.js

@@ -1,5 +1,5 @@
-/* global test:false, expect:false, describe:false, */
-
+const { test, describe } = require('test')
+const expect = require('expect').default
 const headerSanitize = require('../../src/server/header-blacklist')
 
 describe('Header black-list testing', () => {

packages/@uppy/companion/test/__tests__/http-agent.js

@@ -1,5 +1,5 @@
-/* global test:false, expect:false, describe:false, */
-
+const { test, describe } = require('test')
+const expect = require('expect').default
 const request = require('request')
 const http = require('node:http')
 const https = require('node:https')
@@ -20,49 +20,43 @@ describe('test getRedirectEvaluator', () => {
     },
   }
 
-  test('when original URL has "https:" as protocol', (done) => {
+  test('when original URL has "https:" as protocol', () => {
     const shouldRedirectHttps = getRedirectEvaluator(httpsURL, true)
     expect(shouldRedirectHttps(httpsRedirectResp)).toEqual(true)
     expect(shouldRedirectHttps(httpRedirectResp)).toEqual(false)
-    done()
   })
 
-  test('when original URL has "http:" as protocol', (done) => {
+  test('when original URL has "http:" as protocol', () => {
     const shouldRedirectHttp = getRedirectEvaluator(httpURL, true)
     expect(shouldRedirectHttp(httpRedirectResp)).toEqual(true)
     expect(shouldRedirectHttp(httpsRedirectResp)).toEqual(false)
-    done()
   })
 })
 
 describe('test getProtectedHttpAgent', () => {
-  test('setting "https:" as protocol', (done) => {
+  test('setting "https:" as protocol', () => {
     const Agent = getProtectedHttpAgent('https:')
     expect(Agent).toEqual(https.Agent)
-    done()
   })
 
-  test('setting "https" as protocol', (done) => {
+  test('setting "https" as protocol', () => {
     const Agent = getProtectedHttpAgent('https')
     expect(Agent).toEqual(https.Agent)
-    done()
   })
 
-  test('setting "http:" as protocol', (done) => {
+  test('setting "http:" as protocol', () => {
     const Agent = getProtectedHttpAgent('http:')
     expect(Agent).toEqual(http.Agent)
-    done()
   })
 
-  test('setting "http" as protocol', (done) => {
+  test('setting "http" as protocol', () => {
     const Agent = getProtectedHttpAgent('http')
     expect(Agent).toEqual(http.Agent)
-    done()
   })
 })
 
 describe('test protected request Agent', () => {
-  test('allows URLs without IP addresses', (done) => {
+  test('allows URLs without IP addresses', (context, done) => {
     const options = {
       uri: 'https://transloadit.com',
       method: 'GET',
@@ -80,7 +74,7 @@ describe('test protected request Agent', () => {
     })
   })
 
-  test('blocks private http IP address', (done) => {
+  test('blocks private http IP address', (context, done) => {
     const options = {
       uri: 'http://172.20.10.4:8090',
       method: 'GET',
@@ -94,7 +88,7 @@ describe('test protected request Agent', () => {
     })
   })
 
-  test('blocks private https IP address', (done) => {
+  test('blocks private https IP address', (context, done) => {
     const options = {
       uri: 'https://172.20.10.4:8090',
       method: 'GET',
@@ -108,7 +102,7 @@ describe('test protected request Agent', () => {
     })
   })
 
-  test('blocks localhost IP address', (done) => {
+  test('blocks localhost IP address', (context, done) => {
     const options = {
       uri: 'http://127.0.0.1:8090',
       method: 'GET',

packages/@uppy/companion/test/__tests__/logger.js

@@ -1,4 +1,5 @@
-/* global test:false, expect:false, describe:false, beforeAll:false, */
+const { it: test, describe, before: beforeAll } = require('test')
+const expect = require('expect').default
 const chalk = require('chalk')
 const logger = require('../../src/server/logger')
 

packages/@uppy/companion/test/__tests__/preauth.js

@@ -1,6 +1,21 @@
-/* global jest:false, test:false, expect:false, describe:false */
-
-jest.mock('../../src/server/helpers/jwt', () => {
+function mock (package, replacer) {
+  const actualPath = require.resolve(package)
+  if (arguments.length === 1) {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    require.cache[actualPath] = require(`../__mocks__/${package}`)
+  } else {
+    const Module = require('node:module') // eslint-disable-line global-require
+    require.cache[actualPath] = new Module(actualPath, module)
+    Object.defineProperties(require.cache[actualPath], {
+      exports: {
+        __proto__: null,
+        value: replacer(),
+      },
+      resetFn: { __proto__: null, value: replacer },
+    })
+  }
+}
+mock('../../src/server/helpers/jwt', () => {
   return {
     generateToken: () => {},
     verifyToken: () => {},
@@ -15,6 +30,8 @@ jest.mock('../../src/server/helpers/jwt', () => {
   }
 })
 
+const { test, describe } = require('test')
+const expect = require('expect').default
 const request = require('supertest')
 const { getServer } = require('../mockserver')
 // the order in which getServer is called matters because, once an env is passed,

packages/@uppy/companion/test/__tests__/provider-manager.js

@@ -1,5 +1,5 @@
-/* global jest:false, test:false, expect:false, describe:false, beforeEach:false */
-
+const { beforeEach, describe, it:test } = require('test')
+const expect = require('expect').default
 const providerManager = require('../../src/server/provider')
 const { getCompanionOptions } = require('../../src/standalone/helper')
 const { setDefaultEnv } = require('../mockserver')
@@ -148,7 +148,7 @@ describe('Test Custom Provider options', () => {
           key: 'foo_key',
           secret: 'foo_secret',
         },
-        module: jest.mock(),
+        module: {},
       },
     }, providers, grantConfig)
 

packages/@uppy/companion/test/__tests__/providers.js

@@ -1,17 +1,44 @@
-/* global jest:false, test:false, expect:false, describe:false */
-
-jest.mock('tus-js-client')
-jest.mock('purest')
-jest.mock('../../src/server/helpers/request', () => {
+function mock (package, replacer) {
+  const actualPath = require.resolve(package)
+  if (arguments.length === 1) {
+    // eslint-disable-next-line import/no-dynamic-require,global-require
+    require.cache[actualPath] = require(`../__mocks__/${package}`)
+  } else {
+    const Module = require('node:module') // eslint-disable-line global-require
+    require.cache[actualPath] = new Module(actualPath, module)
+    Object.defineProperties(require.cache[actualPath], {
+      exports: {
+        __proto__: null,
+        value: replacer(),
+      },
+      resetFn: { __proto__: null, value: replacer },
+    })
+  }
+}
+mock('tus-js-client')
+mock('purest')
+mock('../../src/server/helpers/request', () => {
   return {
     getURLMeta: () => Promise.resolve({ size: 758051 }),
   }
 })
-jest.mock('../../src/server/helpers/oauth-state', () => require('../mockoauthstate')())
+mock('../../src/server/helpers/oauth-state', () => require('../mockoauthstate')())
 
+const { before: beforeAll, after: afterAll, describe, it } = require('test')
+const expect = require('expect').default
 const request = require('supertest')
 const nock = require('nock')
 
+const test = {
+  each (iterable) {
+    return (message, fn) => {
+      for (const val of iterable) {
+        it(message, fn.bind(null, val))
+      }
+    }
+  },
+}
+
 const fixtures = require('../fixtures')
 const tokenService = require('../../src/server/helpers/jwt')
 const { getServer } = require('../mockserver')

packages/@uppy/companion/test/__tests__/subpath.js

@@ -1,3 +1,4 @@
+const { it, test } = require('test')
 const request = require('supertest')
 const { getServer } = require('../mockserver')