Repository navigation
Add the Acme A3 architecture worked example to the library - #106
Merged
Merged
Conversation
transitrix
marked this pull request as ready for review
October 21, 2026 10:20
vkgeorgia
approved these changes
Oct 21, 2026
vkgeorgia
left a comment
vkgeorgia
left a comment
Collaborator
There was a problem hiding this comment.
Independent review of all 10 changed files at 636d9e0 found no actionable issues. Cross-checked the text and rendered PDF/PNG against actual source model, sidecars and corrected report. PDF is one legible A3 landscape page; checksum matches. The named A3 exception is confined to this library item and preserves reference-sheet/explainer refusal checks. Independently passed 18 tests, library/explainer checks, manifest, 62-file build/archive, sitemap comparison and whitespace checks. Acme source PR #99 is merged and its main report bytes match the reviewed source. Publication is separate from this source approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds /library/acme-architecture-on-a-page/ with an A3 PDF, full-size preview, six-cell text reading, pinned model/report sources and explicit manual-assembly and snapshot limits. The library index, sitemap, discovery file, checksums and consumer manifest include the new item.
The PDF checker admits 420 × 297 mm only for this named library example; existing reference-sheet and explainer geometry stays enforced. Five format-admission cases cover the A3 success and wrong-size/scope refusals.
Validation: independent review found no issues; 18 artifact/deployment tests, library/explainer checks and the exact 62-file consumer build/archive pass. The one-page A3 PDF was visually inspected. Browser checks cover desktop, 390px and 320px layouts, light/dark themes, library navigation and PDF opening. Report source correction: transitrix/acme-corp#99, merged first. Publication remains separately controlled.