Repository navigation
Fix numeric release drift and stale automated reminders - #661
Conversation
Signed-off-by: dot <automation@korobeinikov.consulting>
Signed-off-by: dot <automation@korobeinikov.consulting>
transitrix
left a comment
There was a problem hiding this comment.
Independent read-only source review completed by a separate reviewer run at exact head 7431fcfdd191697acfe7bcbf85ff82a397003e19. No blocking findings in the full four-file diff.
The reviewer independently executed all 22 reminder regression tests, all 5 publish-manifest tests and workflow-script integrity. Verified numeric threshold boundaries, stale reminder closure without release claims, unchanged rerun behavior, exclusion of manually maintained issues, duplicate/malformed-input refusal and preserved 403 failures. PR execution has read-only permissions; the issue-write job is excluded on PRs and depends on passing tests. No release action was introduced.
This records independent source review; exact-head CI and supported merge remain separate checks.
What changed
Release drift compared string-valued counts, so 8 commits could produce a reminder claiming to exceed a threshold of 50. Parse and validate numeric inputs before comparing, and reconcile the title, body and state of workflow-owned reminders. Below-threshold closure explicitly does not claim a release was prepared or published. Preserve manually maintained release issues and refuse ambiguous duplicate reminders.
PRs run the 22 reminder regression tests with read-only permissions; issue writes remain limited to scheduled/manual reconciliation after those tests pass. Declare the scripts in the existing publish manifest. No release is published.
Closes #639.
How it is verified
git diff --checkpasses.Checklist