Skip to content

Distinguish requirement provenance from central-admission origin - #643

Merged
vkgeorgia merged 2 commits into
mainfrom
fix/999-requirement-origin
Oct 9, 2026
Merged

vkgeorgia merged 2 commits into
mainfrom
fix/999-requirement-origin

Conversation

@transitrix-foundry

Copy link
Copy Markdown
Contributor

What changed

Local REQUIREMENT records may use origin: legislative, process-product, or project-product without BIND-005. Central-admission maps, other element types, and unrecognised or ambiguous origin values retain the error. The binding contract documents the distinction and the bounded scalar reader; authored field names and shapes remain unchanged.

How it is verified

  • All 132 ingest CI unit tests and the deterministic ingest pipeline pass.
  • All 121 documentation tests and notation lint pass (four existing lint warnings).
  • 117 regression cases cover all three provenance values, quoting/comments, absent origin, central maps, malformed/ambiguous values, and other TYPEs. Six actual repo-check CLI controls pass against source and a locally packed consumer with companion vocabulary files. BIND-001 through BIND-004 and legacy boolean inputs remain covered.
  • The broader ingest unit suite passes 224/226. The two failures also reproduce on the unchanged base: dated batch sequence numbering and the privacy scanner's null/undefined assertion.
  • Standalone package startup still requires companion vocabulary files. No package version or publication changes are included.

Checklist

  • Based on main, one concern per PR.
  • Commits are signed off — DCO.
  • Public files, branch, commit message, title, and description reviewed for public-surface hygiene.

Signed-off-by: transitrix <automation@transitrix.com>
Signed-off-by: transitrix <automation@transitrix.com>
@vkgeorgia

Copy link
Copy Markdown
Collaborator

Independent exact-head review completed at 9214bb577312dc8fa4b27b9df4a615287b86a102. The initial head changed BIND-005 origin semantics without committed regression coverage; this was repaired on the same PR with positive taxonomy-scalar and negative central-map, unknown, duplicate, nested, and wrong-TYPE cases. Focused catalogue/repo-check suite: 59/59 passed. The broader ingest suite has the same two unrelated pre-existing failures reproduced on baseline (date-bound batch path and privacy null/undefined); no new failure is introduced. All hosted exact-head checks are successful or intentionally skipped. Accepted for squash merge.

@vkgeorgia
vkgeorgia merged commit 49c7d52 into main Oct 9, 2026
18 checks passed
@vkgeorgia
vkgeorgia deleted the fix/999-requirement-origin branch October 9, 2026 05:53
@vkgeorgia

Copy link
Copy Markdown
Collaborator

Correction to the preceding review note: the exact reviewed and merged PR head is 9214bb5af440c316b15c7fa87eb1ad54348817f3 (the prior note transcribed the suffix incorrectly). All other review evidence and disposition are unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants