Repository navigation
Align skill guidance and isolate intake profiles - #641
Conversation
Signed-off-by: transitrix <automation@transitrix.com>
vkgeorgia
left a comment
There was a problem hiding this comment.
Exact-head review of f421b19 found one fail-open compatibility gap. The new contract requires _intake/profile.json to be committed, but checkIntakeProfile() checks Git visibility only for the synthetic/processed OKF paths. Reproduction in a clean Git repo: add _intake/profile.json to .gitignore, then run transitrix-intake-profile select <repo> --profile knowledge-store; it exits 0 and writes the marker, while git check-ignore --no-index _intake/profile.json confirms it is ignored and git status --ignored shows !! _intake/. A later clone therefore loses the declared profile and can be misclassified. Please fail closed when the marker itself cannot be committed (for both supported profiles where the docs require committing it) and add a regression covering a marker-specific ignore rule without mutating existing data. Targeted independent tests otherwise passed: 26/26 intake-profile and 121/121 notation/release checks; doc lint, cheat-sheet, workflow references and diff hygiene passed. Two unrelated broad ingest-suite failures reproduce unchanged on parent fe13693 and are not findings on this PR.
|
A second bounded consequence of the same explicit-selection contract: the installed |
Signed-off-by: transitrix <automation@transitrix.com>
vkgeorgia
left a comment
There was a problem hiding this comment.
Independent exact-head acceptance of 4270921. The repair closes both review findings: profile selection now fails closed when _intake/profile.json is ignored for either profile, including tracked/new and negation cases, and the installed reg-intel daily driver records the ingest selection before downstream CLI/network/state activity while preserving matching markers. Independent verification passed 36/36 intake-profile tests plus the complete ingest and reg-intel integrity suites; git diff --check is clean. All applicable hosted checks on this exact head succeeded (18 success; intentional skips/neutral only).
What changed
Intake setup now selects either an ingest/reg-intel workspace with private processed raw files or an OKF knowledge-store workspace with committed source records. A shared preflight checks existing content and Git ignore rules, refuses conflicting profiles before setup writes, and records the selected profile without migrating data. Both profiles reject ignored markers before writing, and the daily regulatory driver records a missing ingest selection before invoking downstream commands while preserving an existing matching marker. It ships as the standalone
transitrix-intake-profilebinary; ingest scaffolding and the regulatory driver use the guard.Skill guidance now supports both Goals authoring forms, routes scrubbed feedback through the existing local journal, distinguishes adopter-repository PR delivery from upstream export, and requires reviewed IDs and canonical placement before a knowledge-store canon PR. Relation proposals remain medium confidence or lower. Maintainer-only guidance is removed from the feedback execution protocol.
How it is verified
git diff --checkpass. The notation checker retains four existing advisory warnings.Checklist
main, one concern per PR.