Update the interface with asimov#57
Conversation
…d logging and injection parameters
There was a problem hiding this comment.
Pull request overview
This PR updates the interface between heron and asimov to improve compatibility and functionality. The changes focus on modernizing the template structure, fixing a spelling error, enabling pesummary integration, and improving the pipeline submission process.
Changes:
- Enabled pesummary imports in utils.py by uncommenting previously disabled imports
- Restructured the asimov template configuration to use conditional sections and improved parameter handling
- Added Python version compatibility handling for importlib.resources (Python 3.9+ vs earlier versions)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| heron/utils.py | Uncommented pesummary import statements to enable functionality |
| heron/asimov/heron_template.yml | Fixed spelling error, restructured template with conditional sections and improved parameter access patterns |
| heron/asimov/init.py | Added importlib compatibility handling, updated pipeline arguments, improved build_dag with dry-run support and better argument construction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Handle importlib.resources compatibility across Python versions | ||
| if sys.version_info >= (3, 9): | ||
| from importlib.resources import files | ||
| else: | ||
| from importlib_resources import files |
There was a problem hiding this comment.
The code imports importlib_resources for Python versions below 3.9, but this dependency is not listed in requirements.txt or pyproject.toml. Add importlib_resources; python_version < "3.9" to the dependencies to ensure the package is available when needed.
Update the interface between heron and asimov.