Skip to content
This repository was archived by the owner on Sep 23, 2024. It is now read-only.

Conversation

@canassa
Copy link

@canassa canassa commented Sep 8, 2023

Problem

Currently, the project specifies an upper-bound limit for the Python version as <3.10. This could potentially limit the usage of the project for environments with newer Python versions, even if the project is compatible with them.

Proposed changes

This PR removes the upper-bound limit for the Python version. By doing so, the project can be used in environments with Python versions greater than 3.9 without the need for overriding or bypassing the specified requirements.

I executed both the unit tests and the integration tests with Python 3.11 and they are both passing ✅

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@canassa canassa force-pushed the remove-upper-bound-python-limit branch from 208c9d0 to 82085b4 Compare September 8, 2023 08:04
@TyShkan
Copy link

TyShkan commented Oct 19, 2023

The upper bound limit also forcing Meltano to install 1.8.4 version in python 3.10+ environments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants