Add option to start interactive server for Parser dialect conversion

[frabert]

Known issues:

• The conversion pass uses a shared_ptr to the server in order to allow the pass to be cloneable -- it's not super elegant
• This currently asks the user for a lot of information about functions

[xlauko]

This does not work as dst is not output parameter and you overwrite it.

You are only lucky it is used with single character span.

Also why to introduce unnecessary complexity when only thing you use is read_byte? read_some is also nowhere else used then in read of single byte.

[frabert]

I don't understand the thing about dst being overwritten

re read_some: read_some is the only semantic that most APIs offer, but for convenience sake I also want read_all semantics, for example when reading a request's body.

[xlauko]

What do you expect to be in dst at the end of read_all? You rewrite it at every iteration what is invisible from outside.

[frabert]

dst is a span -- it's essentially a pointer char*. It's equivalent to

void read_all(char *start, char *end) {
  while(start != end) {
    do_something(start);
    ++start;
  }
}

dst.subspan returns a new span that points to the same data but nread characters ahead

[xlauko]

Oh I misunderstood it. I guess it works :)

[xlauko]

use core::function_op_interface everywhere instead of hl::FuncOp

[frabert]

I can't find an equivalent of getSymName() for FunctionOpInterface

[xlauko]

dyn_cast<SymbolOpInterface>(op.getOperation()).getName()

[xlauko]

and some checks you really have symbol

[github-actions]

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v19.1.1) reports: 1 concern(s)

• include/vast/Conversion/Parser/Passes.hpp:22:14: error: [clang-diagnostic-error]

  'vast/Conversion/Parser/Passes.h.inc' file not found

     22 |     #include "vast/Conversion/Parser/Passes.h.inc"
        |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.