Use apt clang instead of manually installing clang #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
-lstdc++
fixes issues like:Changing the dummy code was necessary because older versions of clang do not set
detect_stack_use_after_return=1
by default. Instead of adding this to the environment, I decided to use different ASAN violation code so we don't requireASAN_OPTIONS
modification.There's some debate as to whether we should use
-lstdc++
or-lc++
. I'm not sure what the right answer is, but-lstdc++
works for me while-lc++
doesn't. These links may help give some context or recommendations: