Skip to content

fix(langchain): changed dictionary access from spans[run_id] to spans.get(run_id) #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 23, 2025
Merged

fix(langchain): changed dictionary access from spans[run_id] to spans.get(run_id) #3403

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27213ef
Changed dictionary access from spans[run_id] to spans.get(run_id) to …
shivampatel-bwater Oct 9, 2025
5afa753
Remove verbose comments
shivampatel-bwater Oct 10, 2025
383ed2a
Add tests for external run_id handling
shivampatel-bwater Oct 10, 2025
f45add1
fix linter and remove test
shivampatel-bwater Oct 23, 2025
55c5f40
Merge branch 'main' into shivampatel/fix-key-issue
Shivamp629 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions ...entelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,16 +229,18 @@ def __call__(
run_manager = kwargs.get("run_manager")
if run_manager:
run_id = run_manager.run_id
span_holder = self._callback_manager.spans[run_id]

extra_headers = kwargs.get("extra_headers", {})

# Inject tracing context into the extra headers
ctx = set_span_in_context(span_holder.span)
TraceContextTextMapPropagator().inject(extra_headers, context=ctx)

# Update kwargs to include the modified headers
kwargs["extra_headers"] = extra_headers
span_holder = self._callback_manager.spans.get(run_id)

if span_holder:
extra_headers = kwargs.get("extra_headers", {})
ctx = set_span_in_context(span_holder.span)
TraceContextTextMapPropagator().inject(extra_headers, context=ctx)
kwargs["extra_headers"] = extra_headers
else:
logger.debug(
"No span found for run_id %s, skipping header injection",
run_id
)

# In legacy chains like LLMChain, suppressing model instrumentations
# within create_llm_span doesn't work, so this should helps as a fallback
Expand Down