feat: added range onnx import #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JachymPutta
force-pushed
the
jp/range_onnx_import
branch
2 times, most recently
from
62ae485 to
dfd0290
Compare
JachymPutta
force-pushed
the
jp/range_onnx_import
branch
from
dfd0290 to
99f0f56
Compare
JachymPutta
force-pushed
the
jp/range_onnx_import
branch
from
a8787df to
d1f883a
Compare
JachymPutta
force-pushed
the
jp/range_onnx_import
branch
from
d1f883a to
9dcc11a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
+ Coverage 86.42% 86.44% +0.02%
==========================================
Files 761 762 +1
Lines 87987 88111 +124
==========================================
+ Hits 76041 76166 +125
+ Misses 11946 11945 -1 ☔ View full report in Codecov by Sentry. |
laggui
requested changes
May 30, 2024
Comment on lines
27
to
49
| let start = match &self.start { | ||
| Type::Scalar(s) => { | ||
| let name = s.name.clone(); | ||
| quote! { #name } | ||
| } | ||
| _ => panic!("Start must be a scalar"), | ||
| }; | ||
|
|
||
| let end = match &self.end { | ||
| Type::Scalar(s) => { | ||
| let name = s.name.clone(); | ||
| quote! { #name } | ||
| } | ||
| _ => panic!("End must be a scalar"), | ||
| }; | ||
|
|
||
| let step = match &self.step { | ||
| Type::Scalar(s) => { | ||
| let name = s.name.clone(); | ||
| quote! { #name } | ||
| } | ||
| _ => panic!("Step must be a scalar"), | ||
| }; |
There was a problem hiding this comment.
If the three fields are all supposed to be scalar, I suggest we change the node fields to:
pub struct RangeNode {
pub start: ScalarType,
pub end: ScalarType,
pub step: ScalarType,
pub output: TensorType,
}and the logic to check the extract the scalar types can go in the range_conversion.
There was a problem hiding this comment.
Well yes, scalars are simply represented as 0-dim tensors. Basically what I am suggesting is just to move the type handling outside of the forward node method to the range_conversion function instead, a bit like this:
fn range_conversion(node: Node) -> RangeNode {
let output = node.outputs.first().unwrap().to_tensor_type();
let start = node.inputs.first().unwrap().to_type();
let end = node.inputs.get(1).unwrap().to_type();
let step = node.inputs.get(2).unwrap().to_type();
// Check/convert start, end & step to ScalarType just as it was done in the forward method
// ...
RangeNode::new(start, end, step, output)
}
|
Should be good |
JachymPutta
force-pushed
the
jp/range_onnx_import
branch
from
00f70a9 to
0a2530c
Compare
antimora
approved these changes
May 31, 2024
LilDojd
pushed a commit
to LilDojd/burn
that referenced
this pull request
Jun 5, 2024
* feat: added range onnx import * fix: range input types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks allscript has been executed.Changes
Add the range import to onnx
Testing
cargo test rangeRelated Issue
#1714