Status widget #431

Anton-V-K · 2022-01-30T13:59:12Z

Simple implementation of the status widget (#429).
The base code was generated with Android Studio 2020.3.1.
Testing:

tananaev · 2022-01-30T17:46:14Z

I think some of the comments are not addressed. Can we remove the theme and minimize the number of files/code that we need to add such a simple widget?

Anton-V-K · 2022-01-30T20:32:08Z

Yes, I kept the theme support - users with Android 12+ may benefit from it. Does it make a problem?
I'm not sure which redundant code you see - each piece is needed for the widget to work properly.
And I've dropped images for the widget's preview.

tananaev · 2022-01-30T23:56:31Z

Can you please explain why we need the theme.

Anton-V-K · 2022-01-31T07:56:20Z

I've removed support for style and theme, since they aren't needed for the status widget.

app/src/main/java/org/traccar/client/StatusWidget.kt

app/src/main/res/values/dimens.xml

app/src/main/res/values/strings.xml

app/src/main/res/xml/status_widget_info.xml

app/src/main/res/values/attrs.xml

app/src/main/res/layout/status_widget.xml

Anton-V-K · 2023-03-03T22:38:09Z

Wow! A year has passed! :)
I wonder if anything else is required from my side to make this mini-feature ready for merging?

tananaev

Sorry, looks like I forgot about it back then. Added some comments.

app/src/main/res/layout/status_widget.xml

app/src/main/res/values/dimens.xml

app/src/main/res/values/strings.xml

app/src/main/java/org/traccar/client/StatusWidget.kt

…minor changes) traccar#429

Anton-V-K · 2023-08-01T22:29:00Z

New changes are ready for another review round :)

tananaev

Looks much better. Added some very minor comments.

app/src/main/java/org/traccar/client/StatusWidget.kt

app/src/main/res/xml/status_widget_info.xml

app/src/main/java/org/traccar/client/StatusWidget.kt

Anton-V-K · 2023-08-13T15:13:41Z

I've performed more testing of the recent build on several versions of Android (virtualized), and noticed that the widget isn't updated any longer when the service is started/stopped (via the shortcut or from within the app).
The update works for:

6.0 (Samsung Galaxy S6)
7.0 (Pixel 2)
9.0 (Amazon Fire HD 10)

It doesn't happen for:

8.1 (Samsung Galaxy S8)
10 (Samsung Galaxy S10)
11 (Realmi 8i, real device)

The only significant change between the builds is the way how intent's handlers are registered for the widget: explicitly (old build) or in the app's manifest (new build).
I guess, there is some limitation/restriction in newer Androids regarding catching custom intents via app's manifest, but I can't find any official ground for this.

tananaev · 2023-08-13T15:24:57Z

Not sure. Maybe there are some limitations or maybe some attributes are missing.

Anton-V-K · 2023-08-22T09:22:19Z

I've found the reason why the widget doesn't receive custom notifications - since Android 8 (API level 26) the system imposes additional restrictions on manifest-declared receivers (reference):

If your app targets Android 8.0 or higher, you cannot use the manifest to declare a receiver for most implicit broadcasts (broadcasts that don't target your app specifically). You can still use a context-registered receiver when the user is actively using your app.

Possible workarounds:

Old approach with explicitly registered receiver (in StatusWidget.onEnabled)
Context-registered reciever (probably in StatusWidget.onEnabled, requires AndroidX Core library 1.9.0+)
Specify package name for intents when sending broadcasts (in TrackingService.onCreate and TrackingService.onDestroy) - this approach also works as expected. The changes are as follows:
- sendBroadcast(Intent(ACTION_STARTED).setPackage(packageName)) in TrackingService.onCreate()
- sendBroadcast(Intent(ACTION_STOPPED).setPackage(packageName)) in TrackingService.onDestroy()

Which way is preferred?
Any other ideas?

tananaev · 2023-08-22T13:39:32Z

Does the last option allow us to keep XML registration? Then I like that one.

Anton-V-K · 2023-08-22T21:08:36Z

Yes, the option 3 goes on top of the current implementation with manifest-registered receiver with custom intents filter.
Other options don't require custom intents filter in AndroidManifest.xml for the status widget.

…date; minor refactoring of update; clean-up) traccar#429

Anton-V-K · 2023-08-23T17:51:37Z

Ooops! There is an easy-to-resolve conflict in TrackingService.onCreate :(
Should I merge and resolve conventionally or should I try to rebase my changes on top of master?

tananaev · 2023-08-23T18:20:04Z

Both merge and rebase are fine.

Anton-V-K · 2023-08-24T10:08:42Z

I've merged master into the widget's branch locally, and now I get more warnings during the build:

> Task :app:compileRegularDebugKotlin
w: file:///.../app/src/main/java/org/traccar/client/AndroidPositionProvider.kt:57:34
    This declaration overrides deprecated member but not marked as deprecated itself.
    This deprecation won't be inherited in future releases. Please add @Deprecated annotation or suppress.
    See https://youtrack.jetbrains.com/issue/KT-47902 for details
w: file:///.../app/src/main/java/org/traccar/client/BatteryOptimizationHelper.kt:58:40
    'resolveActivity(Intent, Int): ResolveInfo?' is deprecated. Deprecated in Java
w: file:///.../app/src/main/java/org/traccar/client/MainFragment.kt:249:21
    'requestPermissions(Array<(out) String!>, Int): Unit' is deprecated. Deprecated in Java
w: file:///.../app/src/main/java/org/traccar/client/MainFragment.kt:268:21
    'requestPermissions(Array<(out) String!>, Int): Unit' is deprecated. Deprecated in Java
w: file:///.../app/src/main/java/org/traccar/client/TrackingService.kt:49:13
    'stopForeground(Boolean): Unit' is deprecated. Deprecated in Java
w: file:///.../app/src/main/java/org/traccar/client/TrackingService.kt:93:9
    'stopForeground(Boolean): Unit' is deprecated. Deprecated in Java

I haven't tried to build master separately, so I'm not sure whether these warnings are accceptable.
It seems these warnings aren't in my code, so may I push without fixing them?

tananaev · 2023-08-24T13:03:54Z

If they're the same on master, it should be fine.

…et with minor changes for traccar#429 # Resolved conflicts: # app/src/main/java/org/traccar/client/TrackingService.kt

Anton-V-K · 2023-08-24T15:13:12Z

I've merged master into the widget's branch and applied few minor changes to address warnings in my code.

app/src/main/java/org/traccar/client/StatusWidget.kt

app/src/main/java/org/traccar/client/TrackingService.kt

tananaev · 2023-08-24T20:51:25Z

Merged, thanks for fixing all the feedback. I know it was a lot.

Anton-V-K added 2 commits January 23, 2022 14:51

Status Widget traccar#429

2667f61

Status Widget traccar#429

9360ed2

Anton-V-K mentioned this pull request Jan 30, 2022

Status Widget #429 #430

Closed

11 tasks

Status Widget (removed style and theme support) traccar#429

f003a0f

tananaev reviewed Jan 31, 2022

View reviewed changes

Status Widget (cleanup) traccar#429

aa688b8

tananaev reviewed Mar 4, 2023

View reviewed changes

Status Widget (intents in manifest instead of extra receiver + other …

963e357

…minor changes) traccar#429

tananaev reviewed Aug 1, 2023

View reviewed changes

Status Widget (explicit package name for Android 8+; disabled auto-up…

d6289c7

…date; minor refactoring of update; clean-up) traccar#429

Status Widget (main window is shown on click) traccar#429

e81fdec

Merge remote-tracking branch 'remotes/origin/master' into status_widg…

7687f0a

…et with minor changes for traccar#429 # Resolved conflicts: # app/src/main/java/org/traccar/client/TrackingService.kt

tananaev reviewed Aug 24, 2023

View reviewed changes

app/src/main/java/org/traccar/client/StatusWidget.kt Outdated Show resolved Hide resolved

app/src/main/java/org/traccar/client/TrackingService.kt Outdated Show resolved Hide resolved

Status Widget (comments) traccar#429

232fecc

Anton-V-K mentioned this pull request Aug 24, 2023

Color resources for drawable icons #454

Open

tananaev merged commit f7ecc48 into traccar:master Aug 24, 2023

tananaev mentioned this pull request Nov 30, 2023

Samsung Galaxy Watch6 LTE - WearOS - Working but the app closes by itself traccar/traccar#5227

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Status widget #431

Status widget #431

Anton-V-K commented Jan 30, 2022 •

edited

Loading

tananaev commented Jan 30, 2022

Anton-V-K commented Jan 30, 2022 •

edited

Loading

tananaev commented Jan 30, 2022

Anton-V-K commented Jan 31, 2022

Anton-V-K commented Mar 3, 2023

tananaev left a comment

Anton-V-K commented Aug 1, 2023

tananaev left a comment

Anton-V-K commented Aug 13, 2023 •

edited

Loading

tananaev commented Aug 13, 2023

Anton-V-K commented Aug 22, 2023 •

edited

Loading

tananaev commented Aug 22, 2023

Anton-V-K commented Aug 22, 2023

Anton-V-K commented Aug 23, 2023

tananaev commented Aug 23, 2023

Anton-V-K commented Aug 24, 2023 •

edited

Loading

tananaev commented Aug 24, 2023

Anton-V-K commented Aug 24, 2023

tananaev commented Aug 24, 2023

Status widget #431

Status widget #431

Conversation

Anton-V-K commented Jan 30, 2022 • edited Loading

tananaev commented Jan 30, 2022

Anton-V-K commented Jan 30, 2022 • edited Loading

tananaev commented Jan 30, 2022

Anton-V-K commented Jan 31, 2022

Anton-V-K commented Mar 3, 2023

tananaev left a comment

Choose a reason for hiding this comment

Anton-V-K commented Aug 1, 2023

tananaev left a comment

Choose a reason for hiding this comment

Anton-V-K commented Aug 13, 2023 • edited Loading

tananaev commented Aug 13, 2023

Anton-V-K commented Aug 22, 2023 • edited Loading

tananaev commented Aug 22, 2023

Anton-V-K commented Aug 22, 2023

Anton-V-K commented Aug 23, 2023

tananaev commented Aug 23, 2023

Anton-V-K commented Aug 24, 2023 • edited Loading

tananaev commented Aug 24, 2023

Anton-V-K commented Aug 24, 2023

tananaev commented Aug 24, 2023

Anton-V-K commented Jan 30, 2022 •

edited

Loading

Anton-V-K commented Jan 30, 2022 •

edited

Loading

Anton-V-K commented Aug 13, 2023 •

edited

Loading

Anton-V-K commented Aug 22, 2023 •

edited

Loading

Anton-V-K commented Aug 24, 2023 •

edited

Loading