🔧 PowerShell 5.1でのgit stderrに対する耐性を向上#443
Conversation
…rence git emits informational messages (CRLF warnings, clone progress) on stderr. Under $ErrorActionPreference = "Stop", PowerShell 5.1 wraps a native command's stderr in NativeCommandError records and promotes them to terminating errors even when the exit code is 0. Relax the preference locally in Update-Repository and Install-Repository, and rely on $LASTEXITCODE to detect real failures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughInstall.ps1 modifies two git-related functions to prevent PowerShell 5.1 from treating native-command stderr as terminating errors. ChangesPowerShell Native Command Error Handling
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📒 Summary of Changes
⚒ Technical Details
install.ps1内のUpdate-RepositoryおよびInstall-Repository関数で、$ErrorActionPreferenceを"Continue"に設定。git diffおよびgit cloneの実行時に、エラーメッセージを無視し、$LASTEXITCODEで実際のエラーを確認。⚠ Points of Caution
Summary by CodeRabbit