Merge pull request #4 from GuilhemN/GuilhemN-patch-1

Fix field variable in NTT constants generation
tprest · Sep 28, 2024 · bc443f7 · bc443f7
2 parents 88d01ed + fccde31
commit bc443f7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ntt.py b/ntt.py
@@ -93,7 +93,7 @@ def intt(f_ntt):
     elif (n == 2):
         f = [0] * n
         f[0] = (i2 * (f_ntt[0] + f_ntt[1])) % q
-        f[1] = (i2 * inv_mod_q[1479] * (f_ntt[0] - f_ntt[1])) % q
+        f[1] = (i2 * inv_mod_q[sqr1] * (f_ntt[0] - f_ntt[1])) % q
     return f
 
 

diff --git a/scripts/generate_constants.sage b/scripts/generate_constants.sage
@@ -19,7 +19,7 @@ phi2048_roots = sum([[sqrt(elt), - sqrt(elt)] for elt in phi1024_roots], [])
 	for q = 12 * 1024 + 1 and n = 4, 8, 16, ..., 1024."""
 q = 12 * 1024 + 1
 Zq = Integers(q)
-phi4_roots_Zq = [sqrt(R(- 1)), - sqrt(R(- 1))]
+phi4_roots_Zq = [sqrt(Zq(- 1)), - sqrt(Zq(- 1))]
 phi8_roots_Zq = sum([[sqrt(elt), - sqrt(elt)] for elt in phi4_roots_Zq], [])
 phi16_roots_Zq = sum([[sqrt(elt), - sqrt(elt)] for elt in phi8_roots_Zq], [])
 phi32_roots_Zq = sum([[sqrt(elt), - sqrt(elt)] for elt in phi16_roots_Zq], [])