Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use TSS with Zephyr #2933

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cplappert
Copy link
Member

WIP to prepare TSS for Zephyr integration.

@drandreas: I would like to have your opinion on this. I noticed that you introduced Zephyr some time ago. This commit overwrites the void* TSS2_TCTI_POLL_HANDLE, since it was not working for me. Would this be a problem from your side?

@cplappert cplappert force-pushed the zephyr-tcti-enabler branch from 10c134b to 6d52390 Compare January 17, 2025 20:44
Signed-off-by: Christian Plappert <[email protected]>
@cplappert cplappert force-pushed the zephyr-tcti-enabler branch from 6d52390 to 4328d4f Compare January 17, 2025 20:52
@drandreas
Copy link
Contributor

drandreas commented Jan 20, 2025

Hi @cplappert thank you for reaching out. It has been a while since did those changes. I also changed to a different team so I'm not up-to-date on the Zephyr integration.

I've reached out to a colleague who is still working on the project. I received the following response (they still use the tpm-tss Zephyr integration): "
The patch is fine in my opinion. I don't understand its description in doc/tss-for-zephyr.md and it seems too complicated to me.

TSS2_TCTI_POLL_HANDLE simply has to be defined. It is only used as a parameter for get_poll_handles which only returns TSS2_TCTI_RC_NOT_IMPLEMENTED.

It is somewhat unattractive that UNUSED is now defined twice with the #include <zephyr/posix/poll.h> and the following warning is issued very often:
.../modules/lib/tpm2-tss/import/src/util/aux_util.h:33: warning: "UNUSED" redefined Line 33: #define UNUSED(x) (void)(x)
"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants