Skip to content

Fix #220: Allow filelock test thread to catch any exceptions #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Fix #220: Allow filelock test thread to catch any exceptions #221

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9607d35
Allow filelock test thread to catch any exceptions
TheMatt2 Apr 5, 2023
878c940
Change except to make Flake happy
TheMatt2 Apr 5, 2023
98e43ff
Make catch `Exception` not `BaseException`
TheMatt2 Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_filelock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def __init__(self, target: Callable[[], None], name: str) -> None:
def run(self) -> None:
try:
super().run()
except RuntimeError: # pragma: no cover
except Exception: # pragma: no cover
self.ex = sys.exc_info() # pragma: no cover

def join(self, timeout: float | None = None) -> None:
Expand Down