Skip to content

feat: add macos microphone input selector#52

Open
zly2006 wants to merge 2 commits into
tover0314-w:mainfrom
zly2006:codex/macos-input-device-selector
Open

feat: add macos microphone input selector#52
zly2006 wants to merge 2 commits into
tover0314-w:mainfrom
zly2006:codex/macos-input-device-selector

Conversation

@zly2006

@zly2006 zly2006 commented Jun 9, 2026

Copy link
Copy Markdown

Summary

  • Add a persisted microphone selection setting with System Default fallback.
  • List available input devices via CPAL and expose them through a Tauri command.
  • Use the selected input device when starting capture, with startup validation for missing devices.
  • Add localized settings labels for the microphone selector.

Validation

  • cargo check
  • npm run format:check
  • NODE_OPTIONS='--localstorage-file=/tmp/opentypeless-vitest-localstorage' npm test
  • npm run build

Notes

  • Device IDs currently use CPAL device names because CPAL does not expose stable cross-platform input device IDs.

@zly2006 zly2006 changed the title [codex] Add macOS microphone input selector feat: add macOS microphone input selector Jun 9, 2026
@zly2006 zly2006 changed the title feat: add macOS microphone input selector feat: add macos microphone input selector Jun 9, 2026
@zly2006
zly2006 marked this pull request as ready for review June 9, 2026 05:21
@zly2006
zly2006 requested a review from tover0314-w as a code owner June 9, 2026 05:21
@tover0314-w

Copy link
Copy Markdown
Owner

Review update: this should be rebuilt before merge.

The feature is valid, but the PR is currently conflicting and should not be resolved by a broad direct merge. The safer path is a focused microphone-input-selector PR that preserves existing recording behavior and has explicit fallback behavior when a saved device disappears.

Expected before landing:

  • resolve conflicts against current main
  • persist selected input device safely
  • fall back clearly if the device is missing/unavailable
  • verify macOS recording still works with default input and selected input
  • add focused config/storage tests where possible

This was not merged into the local issue-remediation branch I just validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants