Enable long double for all targets
#130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since libffi v3.4.6 `long double` types have been defined for all targets. This commit exposes `long double` types for all targets from libffi-rs as well. For the commit enabling `long double` for all targets, see libffi/libffi@cd78b53
|
Yeah I don’t see this as a breaking change, targeting master is good. |
|
Okay, thank you! I guess this is good to go for now then. |
arihant2math
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since libffi v3.4.6,
long doubletypes have been defined for all targets. This pull request exposeslong doubletypes for all targets from libffi-rs as well.This is not a breaking change, but it would still constitute a minor version bump as far as I understand. Let me know if you want me to target the "next" branch instead.
There are no tests for
long doubleas they are (mostly) not really supported by Rust. It is currently possible to write tests for targets wherelong doubleis the same size as double (MSVC, ARMv7 and some PPC configurations?). Further targets should be supported when/iff128is stabilized. For x86(_64) I cannot see that there are any concrete plans to enable support for af80type.Should
long doubles be tested? Eventually kept as they are now (available, but without further support), removed from libffi-rs entirely, or removed frommiddle::Typeas they are not available from Rust?This question might deserve its own issue.I created an issue to discuss howlong doubles should be handled in libffi-rs.