Refactor dockerignore logic into IgnoreSpec type #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the .dockerignore parsing and pattern matching logic from BuildFSSync into a dedicated IgnoreSpec type. This improves code organization, testability, and reusability. Changes: - Create new IgnoreSpec.swift with IgnoreSpec type that takes Data in its initializer and provides shouldIgnore(relPath:isDirectory:) method - Update BuildFSSync to load .dockerignore file data and create an IgnoreSpec instance - Rename DockerignoreTests to IgnoreSpecTests - Add unit tests for IgnoreSpec type This addresses feedback from jglogan in PR apple#879.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address feedback from jglogan in PR apple#879.