Skip to content

Conversation

@floWetzels
Copy link
Contributor

@floWetzels floWetzels commented Apr 25, 2024

This PR adds the path mapping distance to the MergeTreeBarycenter, MergeTreeClustering and MergeTreeTemporalReduction modules. Furthermore, the PlanarGraphLayout has been adapted to also enable a "path based layout" for merge trees. It also contains some bug fixes, additions and minor refactorings for other modules related to merge tree edit distances, e.g. when using BDIEDs in MergeTreeDistanceMatrix, it is now possible to apply the preprocessing steps also available for other distances.

In essence, this PR adds the code for the VIS23 paper "Merge Tree Geodesics and Barycenters with Path Mappings" and further related adaptations.

Some further changes are still pending and will be added by @MatPont soon. So please don't merge until they are finished.

An accompanying ttk-data PR will come soon, too.

floWetzels and others added 30 commits November 2, 2022 13:05
…Distance. Branch Mapping Distance still buggy.
@julien-tierny
Copy link
Collaborator

Wonderful, thanks a lot Florian!
Could you please:

@floWetzels
Copy link
Contributor Author

Yes, I'm on it!

@floWetzels
Copy link
Contributor Author

@julien-tierny If the CI runs through, please remember to wait for the remaining changes by @MatPont to be pushed before merging into dev.
I'm working on the ttk-data example.

@floWetzels
Copy link
Contributor Author

I created the accompanying ttk-data PR: topology-tool-kit/ttk-data#162

@julien-tierny julien-tierny changed the title Path Mapping Barycenters [WIP] Path Mapping Barycenters Jun 27, 2024
@julien-tierny
Copy link
Collaborator

work in progress, see topology-tool-kit/ttk-data#162

@julien-tierny julien-tierny added the WIP work in progress label Jun 27, 2024
@julien-tierny julien-tierny marked this pull request as draft June 27, 2024 09:32
@floWetzels
Copy link
Contributor Author

I think all issues are fixed now. Can you have another look, @julien-tierny?

Also, there seems to be a problem with the macos builds in the CI. Is this a problem from our side or an issue of the CI?

@floWetzels
Copy link
Contributor Author

Anything new on this, @julien-tierny? The CI issues seem to be fixed.

@julien-tierny
Copy link
Collaborator

sorry for my late reply. I'm behind on the TTK PRs these days. I'll try to take care of that as soon as possible.
thanks!

@floWetzels
Copy link
Contributor Author

Hi @julien-tierny, a quick reminder for this PR.
I have another PR in the pipeline that branches from this branch, so it would be great to have this one done before the new one.
It contains the source code of this paper: https://doi.ieeecomputersociety.org/10.1109/TVCG.2025.3567120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants