Pm 1345 trolley trust module #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "id" UUID NOT NULL DEFAULT uuid_generate_v4(), | ||
| "user_id" VARCHAR(80) NOT NULL, | ||
| "verification_id" TEXT NOT NULL, | ||
| "date_filed" TIMESTAMP(6) WITHOUT TIME ZONE NOT NULL, |
There was a problem hiding this comment.
medium
correctness
Ensure that the date_filed column is set to the correct time zone if your application requires time zone awareness. Using TIMESTAMP WITHOUT TIME ZONE might lead to inconsistencies if time zones are not handled properly in the application logic.
There was a problem hiding this comment.
@kkartunov do we really want this to be without timezone?
| try { | ||
| await this.paymentsService.reconcileUserPayments(user.id); | ||
| } catch (e) { | ||
| this.logger.error('Error reconciling user payments', e); |
There was a problem hiding this comment.
medium
maintainability
Consider including more context in the error log, such as the user ID, to aid in debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-1345 - Trust module integration