feat(PM-1792): update workflow run item #91
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ); | ||
| } | ||
|
|
||
| const updateData: any = {}; |
There was a problem hiding this comment.
Consider using a more specific type for updateData instead of any to improve type safety and maintainability.
| workflowRunItemId: itemId, | ||
| content: comment.content, | ||
| parentId: comment.parentId, | ||
| createdBy: '', |
There was a problem hiding this comment.
The createdBy field is being set to an empty string. If this is intentional, consider adding a validation or default value to ensure consistency.
| createdAt: new Date(), | ||
| userId: user.userId as string, | ||
| updatedAt: new Date(), | ||
| updatedBy: '', |
There was a problem hiding this comment.
The updatedBy field is being set to an empty string. If this is intentional, consider adding a validation or default value to ensure consistency.
hentrymartin
changed the title
|
|
||
| const updateData: any = {}; | ||
|
|
||
| if (patchData.upVotes !== undefined) { |
There was a problem hiding this comment.
We should extend the logic here to allow M2M to be able to update everything, except scorecardQuestionId
There was a problem hiding this comment.
@kkartunov Now this logic is updated, can you please do a review again?
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-1792