Feat/ai workflows -> dev #29

kkartunov · 2025-08-27T06:25:21Z

Merge AI Workflows code base in dev to prepare for team work.

Sync with develop

…gger Gitea workflow trigger

Sync up with dev

.env.sample

generateGiteaClient.sh

github-actions · 2025-08-27T06:25:41Z

pnpm-lock.yaml

      eslint:
        specifier: ^9.18.0
-        version: 9.21.0
+        version: 9.21.0([email protected])


The version format for eslint seems incorrect. It appears to have an unexpected addition ([email protected]). Please verify if this is intentional or a formatting error.

github-actions · 2025-08-27T06:25:41Z

pnpm-lock.yaml

      eslint-config-prettier:
        specifier: ^10.0.1
-        version: 10.0.1([email protected])
+        version: 10.0.1([email protected]([email protected]))


The version format for eslint-config-prettier includes ([email protected]([email protected])), which seems inconsistent with typical versioning. Please confirm if this is correct or if it needs adjustment.

github-actions · 2025-08-27T06:25:41Z

pnpm-lock.yaml

      eslint-plugin-prettier:
        specifier: ^5.2.2
-        version: 5.2.3(@types/[email protected])([email protected]([email protected]))([email protected])([email protected])
+        version: 5.2.3(@types/[email protected])([email protected]([email protected]([email protected])))([email protected]([email protected]))([email protected])


The version format for eslint-plugin-prettier includes multiple nested dependencies with ([email protected]). Ensure this is the intended format and verify if jiti is a necessary addition here.

github-actions · 2025-08-27T06:26:00Z

pnpm-lock.yaml

    resolution: {integrity: sha512-j6vWzfrGVfyXxge+O0x5sh6cvxAog0a/4Rdd2K36zCMV5eJ+/+tOAngRO8cODMNWbVRdVlmGZQL2YS3yR8bIUA==}
    engines: {node: '>= 0.4'}

+  [email protected]:


The addition of [email protected] should be verified to ensure it is necessary for the AI Workflows feature. If it is not required, consider removing it to avoid unnecessary dependencies.

github-actions · 2025-08-27T06:26:31Z

pnpm-lock.yaml

    optional: true

-  '@eslint-community/[email protected]([email protected])':
+  '@eslint-community/[email protected]([email protected]([email protected]))':


The addition of ([email protected]) to the @eslint-community/eslint-utils dependency may require verification to ensure compatibility and correctness. Please confirm that this change is intentional and that [email protected] is indeed a necessary dependency for this package.

github-actions · 2025-08-27T06:27:17Z

src/shared/modules/global/gitea.service.ts

+  constructor() {
+    this.giteaClient = new Api({
+      baseURL:
+        process.env.GITEA_BASE_URL || 'https://git.topcoder-dev.com/api/v1',


Consider using a configuration management library or service to manage environment variables more securely and flexibly.

github-actions · 2025-08-27T06:27:17Z

src/shared/modules/global/gitea.service.ts

+      baseURL:
+        process.env.GITEA_BASE_URL || 'https://git.topcoder-dev.com/api/v1',
+      headers: {
+        Authorization: `Bearer ${process.env.GITEA_TOKEN}`,


Consider using a configuration management library or service to manage environment variables more securely and flexibly.

github-actions · 2025-08-27T06:27:17Z

src/shared/modules/global/gitea.service.ts

+            process.env.GITEA_SUBMISSION_REVIEW_NEW_REPO_DEF_BRANCH ||
+            'develop',
+          name: challengeId,
+          private: false,


Consider making the repository private by default for security reasons, unless there's a specific reason for it to be public.

github-actions · 2025-08-27T06:27:23Z

src/shared/modules/global/globalProviders.module.ts

    ResourceApiService,
    EventBusService,
    MemberService,
+    SubmissionBaseService,


Consider checking if SubmissionBaseService is used elsewhere in the module or application. If it's not used, it might be unnecessary to include it here.

github-actions · 2025-08-27T06:27:23Z

src/shared/modules/global/globalProviders.module.ts

    EventBusService,
    MemberService,
+    SubmissionBaseService,
+    GiteaService,


Ensure that GiteaService is correctly implemented and integrated within the application. Verify its dependencies and usage.

github-actions · 2025-08-27T06:27:23Z

src/shared/modules/global/globalProviders.module.ts

    MemberService,
+    SubmissionBaseService,
+    GiteaService,
+    SubmissionScanCompleteOrchestrator,


Verify that SubmissionScanCompleteOrchestrator is properly configured and that its lifecycle is managed correctly within the module.

github-actions · 2025-08-27T06:27:28Z

src/shared/modules/global/submission-scan-complete.orchestrator.ts

+    try {
+      const submission: SubmissionResponseDto =
+        await this.submissionBaseService.getSubmissionById(submissionId);
+      this.logger.log(`Submission details: ${JSON.stringify(submission)}`);


Consider using a more structured logging approach instead of JSON.stringify(submission) to avoid logging potentially sensitive information.

github-actions · 2025-08-27T06:27:28Z

src/shared/modules/global/submission-scan-complete.orchestrator.ts

+        await this.challengeApiService.getChallengeDetail(
+          submission.challengeId!,
+        );
+      this.logger.log(`Challenge details: ${JSON.stringify(challenge)}`);


Consider using a more structured logging approach instead of JSON.stringify(challenge) to avoid logging potentially sensitive information.

github-actions · 2025-08-27T06:27:28Z

src/shared/modules/global/submission-scan-complete.orchestrator.ts

+              challenge.id,
+            );
+          } catch (error) {
+            const errorMessage = `Error processing workflow: ${workflow.workflowId}. Error: ${error.message}.`;


The variable error is used here, but it is not declared in the catch block. Consider using catch (error: any) to ensure TypeScript recognizes the error object.

github-actions · 2025-08-27T06:27:30Z

src/shared/modules/kafka/handlers/submission-scan-complete.handler.ts

 import { BaseEventHandler } from '../base-event.handler';
 import { KafkaHandlerRegistry } from '../kafka-handler.registry';
 import { LoggerService } from '../../global/logger.service';
+import { SubmissionScanCompleteOrchestrator } from '../../global/submission-scan-complete.orchestrator';


Consider checking if the SubmissionScanCompleteOrchestrator import is used in the code. If it's not used, it might be unnecessary and could be removed to keep the code clean.

github-actions · 2025-08-27T06:27:34Z

src/shared/modules/kafka/handlers/submission-scan-complete.handler.ts

      this.logger.log('=== Submission Scan Complete Event ===');
-      this.logger.log('Topic:', this.topic);
-      this.logger.log('Payload:', JSON.stringify(message, null, 2));
+      this.logger.log('Topic: ' + this.topic);


The condition process.env.DISPATCH_AI_REVIEW_WORKFLOWS !== 'true' might be better expressed as process.env.DISPATCH_AI_REVIEW_WORKFLOWS !== 'true' to avoid potential issues with type coercion.

github-actions · 2025-08-27T06:27:35Z

src/shared/modules/kafka/handlers/submission-scan-complete.handler.ts

+        return;
+      }
+
+      if (!message.isInfected) {


Consider adding a null or undefined check for message.isInfected to ensure that the property exists and is a boolean before proceeding with the logic.

github-actions · 2025-08-27T06:27:35Z

src/shared/modules/kafka/handlers/submission-scan-complete.handler.ts

+
+      if (!message.isInfected) {
+        // delegate to orchestrator for further processing
+        await this.orchestrator.orchestrateScanComplete(message.submissionId);


Ensure that message.submissionId is validated or sanitized before using it in the orchestrateScanComplete method to prevent potential security issues.

billsedison and others added 10 commits August 10, 2025 22:23

Merge remote-tracking branch 'origin/develop' into feat/ai-workflows

e9043c4

Gitea workflow trigger

7263f69

Remove mock data

baf33f5

Merge pull request #19 from topcoder-platform/develop

427e28f

Sync with develop

Fix the typo worflowId to workflowId

f863657

ci: remove from dev

de2777a

Merge pull request #18 from topcoder-platform/feat/gitea-workflow-tri…

593ad25

…gger Gitea workflow trigger

clean up workflow triggers

7bc1a44

Merge pull request #26 from topcoder-platform/develop

514905d

Sync up with dev

Merge branch 'develop' into feat/ai-workflows

b810bfb

github-actions bot reviewed Aug 27, 2025

View reviewed changes

.env.sample Show resolved Hide resolved

github-actions bot reviewed Aug 27, 2025

View reviewed changes

generateGiteaClient.sh Show resolved Hide resolved

github-actions bot reviewed Aug 27, 2025

View reviewed changes

kkartunov merged commit 4504a82 into develop Aug 27, 2025
2 checks passed

github-actions bot reviewed Aug 27, 2025

View reviewed changes

Feat/ai workflows -> dev #29

Feat/ai workflows -> dev #29

Uh oh!

Conversation

kkartunov commented Aug 27, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants