-
Notifications
You must be signed in to change notification settings - Fork 9
Update challenge reviewer payment fields #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
phaseId String | ||
basePayment Float? | ||
incrementalPayment Float? | ||
fixedAmount Float? @default(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of fixedAmount
is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.
basePayment Float? | ||
incrementalPayment Float? | ||
fixedAmount Float? @default(0) | ||
baseCoefficient Float? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of baseCoefficient
is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.
incrementalPayment Float? | ||
fixedAmount Float? @default(0) | ||
baseCoefficient Float? | ||
incrementalCoefficient Float? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of incrementalCoefficient
is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.
phaseName String | ||
basePayment Float? | ||
incrementalPayment Float? | ||
fixedAmount Float? @default(0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider aligning the indentation of fixedAmount
with the other fields for consistency.
basePayment Float? | ||
incrementalPayment Float? | ||
fixedAmount Float? @default(0) | ||
baseCoefficient Float? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider aligning the indentation of baseCoefficient
with the other fields for consistency.
incrementalPayment Float? | ||
fixedAmount Float? @default(0) | ||
baseCoefficient Float? | ||
incrementalCoefficient Float? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider aligning the indentation of incrementalCoefficient
with the other fields for consistency.
Updated the challenge schema to match the one in the challenge codebase for the challenge reviewer