Skip to content

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Oct 15, 2025

Updated the challenge schema to match the one in the challenge codebase for the challenge reviewer

@vas3a vas3a requested a review from jmgasper October 15, 2025 12:53
phaseId String
basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of fixedAmount is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.

basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)
baseCoefficient Float?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of baseCoefficient is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.

incrementalPayment Float?
fixedAmount Float? @default(0)
baseCoefficient Float?
incrementalCoefficient Float?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment of incrementalCoefficient is inconsistent with the rest of the fields. Consider aligning it with other field declarations for better readability.

phaseName String
basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider aligning the indentation of fixedAmount with the other fields for consistency.

basePayment Float?
incrementalPayment Float?
fixedAmount Float? @default(0)
baseCoefficient Float?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider aligning the indentation of baseCoefficient with the other fields for consistency.

incrementalPayment Float?
fixedAmount Float? @default(0)
baseCoefficient Float?
incrementalCoefficient Float?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider aligning the indentation of incrementalCoefficient with the other fields for consistency.

@vas3a vas3a merged commit 2ad2cdd into develop Oct 15, 2025
1 check passed
@vas3a vas3a deleted the challenge-reviewer-payment-fields branch October 15, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant