refactor(discover-shared): move FeaturesRegistry into discover-shared

tonyghiani · Apr 12, 2024 · f53b567 · f53b567
1 parent 24585d9
commit f53b567
Show file tree

Hide file tree

Showing 17 changed files with 4 additions and 59 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -363,7 +363,6 @@ examples/discover_customization_examples @elastic/kibana-data-discovery
 x-pack/plugins/discover_enhanced @elastic/kibana-data-discovery
 src/plugins/discover @elastic/kibana-data-discovery
 src/plugins/discover_shared @elastic/kibana-data-discovery @elastic/obs-ux-logs-team
-packages/kbn-discover-features-registry @elastic/kibana-data-discovery
 packages/kbn-discover-utils @elastic/kibana-data-discovery
 packages/kbn-doc-links @elastic/docs
 packages/kbn-docs-utils @elastic/kibana-operations

diff --git a/package.json b/package.json
@@ -411,7 +411,6 @@
     "@kbn/developer-examples-plugin": "link:examples/developer_examples",
     "@kbn/discover-customization-examples-plugin": "link:examples/discover_customization_examples",
     "@kbn/discover-enhanced-plugin": "link:x-pack/plugins/discover_enhanced",
-    "@kbn/discover-features-registry": "link:packages/kbn-discover-features-registry",
     "@kbn/discover-plugin": "link:src/plugins/discover",
     "@kbn/discover-shared-plugin": "link:src/plugins/discover_shared",
     "@kbn/discover-utils": "link:packages/kbn-discover-utils",

diff --git a/packages/kbn-discover-features-registry/README.md b/packages/kbn-discover-features-registry/README.md
diff --git a/packages/kbn-discover-features-registry/jest.config.js b/packages/kbn-discover-features-registry/jest.config.js
diff --git a/packages/kbn-discover-features-registry/kibana.jsonc b/packages/kbn-discover-features-registry/kibana.jsonc
diff --git a/packages/kbn-discover-features-registry/package.json b/packages/kbn-discover-features-registry/package.json
diff --git a/packages/kbn-discover-features-registry/tsconfig.json b/packages/kbn-discover-features-registry/tsconfig.json
diff --git a/...s-registry/src/features_registry.test.tsx → ...tures_registry/features_registry.test.tsx b/...s-registry/src/features_registry.test.tsx → ...tures_registry/features_registry.test.tsx
diff --git a/...eatures-registry/src/features_registry.ts → ...on/features_registry/features_registry.ts b/...eatures-registry/src/features_registry.ts → ...on/features_registry/features_registry.ts
diff --git a/...n-discover-features-registry/src/index.ts → ..._shared/common/features_registry/index.ts b/...n-discover-features-registry/src/index.ts → ..._shared/common/features_registry/index.ts
@@ -7,4 +7,3 @@
  */
 
 export { FeaturesRegistry } from './features_registry';
-export * from './types';
diff --git a/...n-discover-features-registry/src/types.ts → ..._shared/common/features_registry/types.ts b/...n-discover-features-registry/src/types.ts → ..._shared/common/features_registry/types.ts
diff --git a/...s/kbn-discover-features-registry/index.ts → src/plugins/discover_shared/common/index.ts b/...s/kbn-discover-features-registry/index.ts → src/plugins/discover_shared/common/index.ts
@@ -6,4 +6,4 @@
  * Side Public License, v 1.
  */
 
-export * from './src';
+export { FeaturesRegistry } from './features_registry';
diff --git a/...ugins/discover_shared/public/services/discover_features/discover_features_service.mock.ts b/...ugins/discover_shared/public/services/discover_features/discover_features_service.mock.ts
@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { FeaturesRegistry } from '@kbn/discover-features-registry';
+import { FeaturesRegistry } from '../../../common';
 import { DiscoverFeature } from './types';
 
 const registry = new FeaturesRegistry<DiscoverFeature>();

diff --git a/src/plugins/discover_shared/public/services/discover_features/discover_features_service.ts b/src/plugins/discover_shared/public/services/discover_features/discover_features_service.ts
@@ -6,7 +6,7 @@
  * Side Public License, v 1.
  */
 
-import { FeaturesRegistry } from '@kbn/discover-features-registry';
+import { FeaturesRegistry } from '../../../common';
 import { DiscoverFeature } from './types';
 
 export class DiscoverFeaturesService {

diff --git a/src/plugins/discover_shared/public/services/discover_features/types.ts b/src/plugins/discover_shared/public/services/discover_features/types.ts
@@ -6,8 +6,8 @@
  * Side Public License, v 1.
  */
 
-import { FeaturesRegistry } from '@kbn/discover-features-registry';
 import { DataTableRecord } from '@kbn/discover-utils';
+import { FeaturesRegistry } from '../../../common';
 
 /**
  * Features types

diff --git a/tsconfig.base.json b/tsconfig.base.json
@@ -716,8 +716,6 @@
       "@kbn/discover-customization-examples-plugin/*": ["examples/discover_customization_examples/*"],
       "@kbn/discover-enhanced-plugin": ["x-pack/plugins/discover_enhanced"],
       "@kbn/discover-enhanced-plugin/*": ["x-pack/plugins/discover_enhanced/*"],
-      "@kbn/discover-features-registry": ["packages/kbn-discover-features-registry"],
-      "@kbn/discover-features-registry/*": ["packages/kbn-discover-features-registry/*"],
       "@kbn/discover-plugin": ["src/plugins/discover"],
       "@kbn/discover-plugin/*": ["src/plugins/discover/*"],
       "@kbn/discover-shared-plugin": ["src/plugins/discover_shared"],

diff --git a/yarn.lock b/yarn.lock
@@ -4484,10 +4484,6 @@
   version "0.0.0"
   uid ""
 
-"@kbn/discover-features-registry@link:packages/kbn-discover-features-registry":
-  version "0.0.0"
-  uid ""
-
 "@kbn/discover-plugin@link:src/plugins/discover":
   version "0.0.0"
   uid ""
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,4 +7,3 @@
		*/

		export { FeaturesRegistry } from './features_registry';
		export * from './types';