Skip to content

Commit

Permalink
feat(discover-shared): update exports and codeowners
Browse files Browse the repository at this point in the history
  • Loading branch information
Marco Antonio Ghiani committed Apr 9, 2024
1 parent 98645ae commit 5188094
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ examples/developer_examples @elastic/appex-sharedux
examples/discover_customization_examples @elastic/kibana-data-discovery
x-pack/plugins/discover_enhanced @elastic/kibana-data-discovery
src/plugins/discover @elastic/kibana-data-discovery
src/plugins/discover_shared @elastic/kibana-data-discovery @elastic/obs-ux-logs-team
packages/kbn-discover-utils @elastic/kibana-data-discovery
packages/kbn-doc-links @elastic/docs
packages/kbn-docs-utils @elastic/kibana-operations
Expand Down
7 changes: 6 additions & 1 deletion src/plugins/discover_shared/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,9 @@ export function plugin() {
return new DiscoverSharedPlugin();
}

export type { DiscoverSharedPluginSetup, DiscoverSharedPluginStart } from './types';
export type { DiscoverSharedClientSetupExports, DiscoverSharedClientStartExports } from './types';
export type {
ObservabilityLogsAIAssistantFeatureRenderDeps,
ObservabilityLogsAIAssistantFeature,
DiscoverFeature,
} from './services/discover_features';
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Side Public License, v 1.
*/

import { FeaturesRegistry } from '@kbn/discover-utils';
import { DocumentOverview, FeaturesRegistry } from '@kbn/discover-utils';

/**
* Features types
Expand All @@ -19,9 +19,13 @@ import { FeaturesRegistry } from '@kbn/discover-utils';
* It will be opinionatedly used as an additional tool to investigate a log document and
* will be shown on the logs-overview preset tab of the UnifiedDocViewer.
*/

export interface ObservabilityLogsAIAssistantFeatureRenderDeps {
doc: DocumentOverview;
}
export interface ObservabilityLogsAIAssistantFeature {
id: 'observability-logs-ai-assistant';
render: (/* TODO: Update with deps required for this integration */) => React.ReactNode;
render: (deps: ObservabilityLogsAIAssistantFeatureRenderDeps) => React.ReactNode;
}

// This should be a union of all the available client features.
Expand Down

0 comments on commit 5188094

Please sign in to comment.