Skip to content

Optimized join-tuples by using aget and acopy where appropriate. #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimized join-tuples by using aget and acopy where appropriate. #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/datascript/query.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,32 @@

;; Relation algebra

(def typed-aget
#?(:cljs aget
:clj (fn [a i]
(aget ^{:tag "[[Ljava.lang.Object;"} a ^Long i))))

(defn join-tuples [t1 #?(:cljs idxs1
:clj ^{:tag "[[Ljava.lang.Object;"} idxs1)
t2 #?(:cljs idxs2
:clj ^{:tag "[[Ljava.lang.Object;"} idxs2)]
(let [l1 (alength idxs1)
l2 (alength idxs2)
(let [l1 (da/alength idxs1)
l2 (da/alength idxs2)
t1-array? (da/array? t1)
t2-array? (da/array? t2)
t1-acopy? (and t1-array? (= l1 (da/alength t1)))
t2-acopy? (and t2-array? (= l2 (da/alength t2)))
g1 (if t1-array? typed-aget get)
g2 (if t2-array? typed-aget get)
res (da/make-array (+ l1 l2))]
(dotimes [i l1]
(aset res i (#?(:cljs aget :clj get) t1 (aget idxs1 i)))) ;; FIXME aget
(dotimes [i l2]
(aset res (+ l1 i) (#?(:cljs aget :clj get) t2 (aget idxs2 i)))) ;; FIXME aget
(if t1-acopy?
(da/acopy t1 0 l1 res 0)
(dotimes [i l1]
(da/aset res i (g1 t1 (da/aget idxs1 i)))))
(if t2-acopy?
(da/acopy t2 0 l2 res l1)
(dotimes [i l2]
(da/aset res (+ l1 i) (g2 t2 (da/aget idxs2 i)))))
res))

(defn sum-rel [a b]
Expand Down