Regex in isFriendly should be anchored #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found few issues with addresses.
isFriendly
should be anchored otherwise it returnstrue
for invalid addressesparse fails as it should, problem is
isFriendly
notparseFriendly
parseRaw
throws should also returnfalse
fromisRaw
parseFriendly
throws should also returnfalse
fromisFriendly
You can verify by using my tests without change in
isFriendly
and see that address!@#$%^&*AAAAAAAAAAAAAA AAAAAAAAAA AAAAAAAAAAAA A
is considered to be friendly: