Skip to content

Commit

Permalink
cam-configs: remove dev, add TODOs
Browse files Browse the repository at this point in the history
When there's a 'media' field in the config, dev is automatically
found via Media Device's MEDIA_IOC_DEVICE_INFO.

When 'media' is missing, each item in 'devices' must have a
'device' field to look up the dev via VIDIOC_QUERYCAP.
  • Loading branch information
Demon000 committed Nov 1, 2024
1 parent d0c66b4 commit fb1cdae
Show file tree
Hide file tree
Showing 9 changed files with 7 additions and 15 deletions.
3 changes: 0 additions & 3 deletions utils/cam-configs/am62a-fpd.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def gen_imx219_pixel(port):
"entity": f"{dma_ent} {port}",
"fmt": fmt_pix_imx219,
"embedded": False,
"dev": f"/dev/video{port}",
},
],

Expand Down Expand Up @@ -166,7 +165,6 @@ def gen_imx219_meta(port):
"entity": f"CAL output {port + 4}",
"fmt": fmt_pix_imx219_meta,
"embedded": True,
"dev": f"/dev/video{port + 4}",
"display": False,
},
],
Expand Down Expand Up @@ -241,7 +239,6 @@ def gen_ub953_tpg(port):
"entity": f"{dma_ent} {port}",
"fmt": fmt_tpg,
"embedded": False,
"dev": f"/dev/video{port}",
"dra-plane-hack": False,
},
],
Expand Down
1 change: 1 addition & 0 deletions utils/cam-configs/debix-tpg.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

#2592✕1940
configurations["cam0"] = {
# TODO: add 'media' entry
"subdevs": [
{
"entity": "rkisp1_tpg",
Expand Down
1 change: 1 addition & 0 deletions utils/cam-configs/debix.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
configurations = {}

configurations["cam0"] = {
# TODO: add 'media' entry
"subdevs": [
# Camera
{
Expand Down
1 change: 0 additions & 1 deletion utils/cam-configs/desky.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
{
"entity": "UVC Camera*",
"fmt": fmt_pix_1,
"dev": "/dev/video0",
},
],

Expand Down
7 changes: 0 additions & 7 deletions utils/cam-configs/dra76-fpd.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ def gen_imx390_pixel(port):
"entity": f"CAL output {port}",
"fmt": fmt_pix_imx390,
"embedded": False,
"dev": f"/dev/video{port}",
"dra-plane-hack": False,
},
],
Expand Down Expand Up @@ -182,7 +181,6 @@ def gen_imx390_meta(port):
"entity": f"CAL output {port + 4}",
"fmt": fmt_pix_imx390_meta,
"embedded": True,
"dev": f"/dev/video{port + 4}",
"display": False,
},
],
Expand Down Expand Up @@ -255,7 +253,6 @@ def gen_imx219_pixel(port):
"entity": f"CAL output {port}",
"fmt": fmt_pix_imx219,
"embedded": False,
"dev": f"/dev/video{port}",
"dra-plane-hack": False,
},
],
Expand Down Expand Up @@ -325,7 +322,6 @@ def gen_imx219_meta(port):
"entity": f"CAL output {port + 4}",
"fmt": fmt_pix_imx219_meta,
"embedded": True,
"dev": f"/dev/video{port + 4}",
"display": False,
},
],
Expand Down Expand Up @@ -398,7 +394,6 @@ def gen_ov10635_pixel(port):
"entity": f"CAL output {port}",
"fmt": fmt_pix_ov10635,
"embedded": False,
"dev": f"/dev/video{port}",
},
],

Expand Down Expand Up @@ -464,7 +459,6 @@ def gen_ov10635_meta(port):
"entity": f"CAL output {port + 4}",
"fmt": fmt_pix_ov10635_meta,
"embedded": True,
"dev": f"/dev/video{port + 4}",
"display": False,
},
],
Expand Down Expand Up @@ -524,7 +518,6 @@ def gen_ub953_tpg(port):
"entity": f"CAL output {port}",
"fmt": fmt_tpg,
"embedded": False,
"dev": f"/dev/video{port}",
"dra-plane-hack": False,
},
],
Expand Down
4 changes: 2 additions & 2 deletions utils/cam-configs/dra76-ov5640.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
configurations["legacy-ov5640"] = {
"devices": [
{
# TODO: add 'device' entry
"fmt": fmt_pix_1,
"dev": "/dev/video0",
},
],
}
Expand All @@ -29,6 +29,7 @@
# DRA76 EVM: OV5640
#
configurations["ov5640"] = {
# TODO: add 'media' entry
"subdevs": [
{
"entity": "ov5640 4-003c",
Expand All @@ -49,7 +50,6 @@
{
"entity": "CAL output 0",
"fmt": fmt_pix_1,
"dev": "/dev/video0",
},
],

Expand Down
2 changes: 1 addition & 1 deletion utils/cam-configs/j7-ov5640.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
configurations = {}

configurations["ov5640"] = {
# TODO: add 'media' entry
"subdevs": [
{
"entity": "ov5640 4-003c",
Expand All @@ -34,7 +35,6 @@
{
"entity": "j721e-csi2rx",
"fmt": fmt_pix_1,
"dev": "/dev/video0",
},
],

Expand Down
2 changes: 1 addition & 1 deletion utils/cam-configs/lappy.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
configurations = {}

configurations["lappy"] = {
# TODO: add 'media' entry
"subdevs": [
],

"devices": [
{
"entity": "Integrated Camera: Integrated C",
"fmt": fmt_pix_1,
"dev": "/dev/video0",
},
],

Expand Down
1 change: 1 addition & 0 deletions utils/cam-configs/rpi4.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
sensor_ent = "imx219 5-0010"

configurations["cam0"] = {
# TODO: add 'media' entry
"subdevs": [
# Camera
{
Expand Down

0 comments on commit fb1cdae

Please sign in to comment.