-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plato to 0.9.1-12 (rM2 bugfix) #166
Conversation
Just tested this on my rm2, running through oxide. Looks like it works! Your description of both the old and new behavior on |
@LinusCDE Since the crash exists on the previous build I'm approving it. Is the power button trying to just do a suspend? |
Yes. It does a suspend with it's own lockscreen. Seems to be an additional bug on the rM 2. Maybe there is some fighting with a launcher, who gets to suspend (i.e. the button press leaks through). On my rM 1 Oxide replaces the suspendscreen without a problem. |
Oxide doesn't pass through the button press ever. The issue on the rM2 is likely the same one we've encountered for oxide where wifi doesn't turn back on properly, and it wasn't waiting long enough to properly draw the custom lockscreen: Eeems-Org/oxide#114 |
Could be. Though if Oxide never passed the button through, I'm wondering why it would crash since it would be just a freeze for plato. This is the script that would get executed should the button actually get pressed for plato. |
Yeah, it wasn't a crash, just a freeze. Indeed with Eeems-Org/oxide#114 installed, Plato behaves just fine when I press the power button now. I think it's just the Oxide bug I was noticing. |
Just noticed, that plato might have a bug on the rM 2, since the
/dev/input/
paths were not changed depending on the model:The above bugs should be present on 0.9.1-11 but not on this version (0.9.1-12). The package is available at https://rmtestrepo.cosmos-ink.net/ for faster testing. The new version will behave the same on the rM 1 (verified it quickly).
As per suggesion from @Eeems in discord, I would recommend that I would be nice, if it could get squeezed into the stable window. (I'm not sure how many actually use this feature if any.)