Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plato to 0.9.1-12 (rM2 bugfix) #166

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

LinusCDE
Copy link
Member

Just noticed, that plato might have a bug on the rM 2, since the /dev/input/ paths were not changed depending on the model:

  • De-selecting "Input by -> Pen" will actually disable the power button (Pen will continue to work).
  • De-selecting "Input by -> Touch" will actually disable the Pen (touch will continue to work).

The above bugs should be present on 0.9.1-11 but not on this version (0.9.1-12). The package is available at https://rmtestrepo.cosmos-ink.net/ for faster testing. The new version will behave the same on the rM 1 (verified it quickly).

As per suggesion from @Eeems in discord, I would recommend that I would be nice, if it could get squeezed into the stable window. (I'm not sure how many actually use this feature if any.)

@LinusCDE LinusCDE requested a review from raisjn December 28, 2020 19:08
@SyntaxBlitz
Copy link

SyntaxBlitz commented Dec 29, 2020

Just tested this on my rm2, running through oxide. Looks like it works! Your description of both the old and new behavior on -11 and -12 match up with my testing, though the power button seems to freeze (and maybe crash?) the app when I press it on either build.

@Eeems
Copy link
Member

Eeems commented Dec 29, 2020

@LinusCDE Since the crash exists on the previous build I'm approving it. Is the power button trying to just do a suspend?

@LinusCDE
Copy link
Member Author

@LinusCDE Since the crash exists on the previous build I'm approving it. Is the power button trying to just do a suspend?

[...] the power button seems to freeze (and maybe crash?) the app when I press it on either build.

Yes. It does a suspend with it's own lockscreen. Seems to be an additional bug on the rM 2. Maybe there is some fighting with a launcher, who gets to suspend (i.e. the button press leaks through). On my rM 1 Oxide replaces the suspendscreen without a problem.

@LinusCDE LinusCDE merged commit 92237a2 into toltec-dev:testing Dec 29, 2020
okayzed pushed a commit to rmkit-dev/toltec that referenced this pull request Dec 29, 2020
@Eeems
Copy link
Member

Eeems commented Dec 29, 2020

@LinusCDE Since the crash exists on the previous build I'm approving it. Is the power button trying to just do a suspend?

[...] the power button seems to freeze (and maybe crash?) the app when I press it on either build.

Yes. It does a suspend with it's own lockscreen. Seems to be an additional bug on the rM 2. Maybe there is some fighting with a launcher, who gets to suspend (i.e. the button press leaks through). On my rM 1 Oxide replaces the suspendscreen without a problem.

Oxide doesn't pass through the button press ever. The issue on the rM2 is likely the same one we've encountered for oxide where wifi doesn't turn back on properly, and it wasn't waiting long enough to properly draw the custom lockscreen: Eeems-Org/oxide#114

@LinusCDE
Copy link
Member Author

Could be. Though if Oxide never passed the button through, I'm wondering why it would crash since it would be just a freeze for plato.

This is the script that would get executed should the button actually get pressed for plato.

@SyntaxBlitz
Copy link

Yeah, it wasn't a crash, just a freeze. Indeed with Eeems-Org/oxide#114 installed, Plato behaves just fine when I press the power button now. I think it's just the Oxide bug I was noticing.

LinusCDE added a commit that referenced this pull request Jan 4, 2021
@LinusCDE LinusCDE deleted the feature/update-plato branch January 14, 2021 00:31
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants