-
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add export formats Apple SDK and Android SDK #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
You can disable this status message by setting the WalkthroughTwo new localization file formats, "APPLE_SDK" and "ANDROID_SDK", were added to the supported formats across the schema, type definitions, and command-line options. The mapping utilities were updated: export mapping now supports these formats, while import mapping explicitly rejects them with clear errors. Documentation comments were clarified regarding namespace scope for certain options. Changes
Sequence Diagram(s)sequenceDiagram
participant CLI
participant mapImportFormat
participant Error
CLI->>mapImportFormat: import(format)
alt format is "APPLE_SDK" or "ANDROID_SDK"
mapImportFormat->>Error: throw InvalidArgumentError("Import not supported")
else other formats
mapImportFormat-->>CLI: return mapped format
end
sequenceDiagram
participant CLI
participant mapExportFormat
CLI->>mapExportFormat: export(format)
alt format is "APPLE_SDK"
mapExportFormat-->>CLI: { format: "APPLE_SDK", messageFormat: "APPLE_SPRINTF" }
else format is "ANDROID_SDK"
mapExportFormat-->>CLI: { format: "ANDROID_SDK", messageFormat: "JAVA_STRING_FORMAT" }
else other formats
mapExportFormat-->>CLI: mapped format object
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Requires tolgee/tolgee-platform#3186
Summary by CodeRabbit
New Features
Bug Fixes
Documentation